From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3359CC43381 for ; Mon, 1 Apr 2019 10:23:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEC9920880 for ; Mon, 1 Apr 2019 10:23:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cPEqVj39" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEC9920880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3p4wQLWZjPMp+FvcB9H5tZvU5vdtY7C0jTbjM5Fg0/k=; b=cPEqVj39+eWLEt sP7fOXGVJISwcp3uzS8afkniMnWZH6jqMMufqMV6YxUXcA417rZjE9iqEKHSYD9HfpehvVlcRvitL qKiklhwDY2Wcs5dWFnvmzNIUlXaVk9acV7JG5XsoAljn1VZRx+zjPuVzczBhJQriSmKkbMrxARUNu StiJi3CjYYDugx/N2WSvao0uNQIJ1Qvymq8SUSJXrj4DKud7BXJaffcK6bnP75XCYxXXrirdEoiil Q6nOiZSQtYQw7ekofqfFYX/Nx5kOHAcglZCkZ9awcmd5iWnUB1C3nJIXsAWcC9zDUDQUp6YaEVuoa vxSvEFr5xOD+JcgOa+Zg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAu6N-0000MO-M7; Mon, 01 Apr 2019 10:23:39 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAu6K-0000M3-PW for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 10:23:38 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id C1F60FB04; Mon, 1 Apr 2019 12:23:34 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 07DnQTbRGG0g; Mon, 1 Apr 2019 12:23:33 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 9AE0444B5C; Mon, 1 Apr 2019 12:23:32 +0200 (CEST) Date: Mon, 1 Apr 2019 12:23:32 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Rob Herring Subject: Re: [PATCH RESEND v7 2/3] dt-bindings: phy: Add documentation for mixel dphy Message-ID: <20190401102332.GA23517@bogon.m.sigxcpu.org> References: <3319783f60fedd7f0029dd60a51c76a75003fe05.1553674604.git.agx@sigxcpu.org> <20190328165729.GA32345@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190328165729.GA32345@bogus> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_032336_990807_575546B1 X-CRM114-Status: GOOD ( 20.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Heiko Stuebner , Maxime Ripard , dri-devel@lists.freedesktop.org, Sam Ravnborg , Abel Vesa , Fabio Estevam , Kishon Vijay Abraham I , NXP Linux Team , Robert Chiras , Thierry Reding , devicetree@vger.kernel.org, Martin Blumenstingl , Sascha Hauer , Johan Hovold , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Lucas Stach , Shawn Guo , Andreas =?iso-8859-1?Q?F=E4rber?= , Li Jun Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Thu, Mar 28, 2019 at 11:57:29AM -0500, Rob Herring wrote: > On Wed, Mar 27, 2019 at 09:20:00AM +0100, Guido G=FCnther wrote: > > Add support for the MIXEL DPHY IP as found in the NXP's i.MX8MQ. > > = > > Signed-off-by: Guido G=FCnther > > Reviewed-by: Sam Ravnborg > > --- > > .../bindings/phy/mixel,mipi-dsi-phy.txt | 29 +++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/mixel,mipi-ds= i-phy.txt > > = > > diff --git a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.t= xt b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.txt > > new file mode 100644 > > index 000000000000..d3646580412a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.txt > > @@ -0,0 +1,29 @@ > > +Mixel DSI PHY for i.MX8 > > + > > +The Mixel MIPI-DSI PHY IP block is e.g. found on i.MX8 platforms (alon= g the > > +MIPI-DSI IP from Northwest Logic). It represents the physical layer fo= r the > > +electrical signals for DSI. > > + > > +Required properties: > > +- compatible: Must be: > > + - "mixel,imx8mq-mipi-dphy" > = > If you had a fallback for mixel, then it would make sense, but as this = > is imx8mq specifc 'fsl' should be the vendor prefix. Fixed in v8. > = > > +- clocks: Must contain an entry for each entry in clock-names. > > +- clock-names: Must contain the following entries: > > + - "phy_ref": phandle and specifier referring to the DPHY ref clock > > +- reg: the register range of the PHY controller > > +- #phy-cells: number of cells in PHY, as defined in > > + Documentation/devicetree/bindings/phy/phy-bindings.txt > > + this must be <0> > > + > > +Optional properties: > > +- power-domains: phandle to power domain > > + > > +Example: > > + mipi_dphy: mipi_dphy@30A0030 { > = > mipi-dphy@... or just dphy@... And this one as well. Thanks for the review! -- Guido > > = > > + compatible =3D "mixel,imx8mq-mipi-dphy"; > > + clocks =3D <&clk IMX8MQ_CLK_DSI_PHY_REF>; > > + clock-names =3D "phy_ref"; > > + reg =3D <0x30A00300 0x100>; > > + power-domains =3D <&pd_mipi0>; > > + #phy-cells =3D <0>; > > + }; > > -- = > > 2.20.1 > > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel