From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C62C43381 for ; Mon, 1 Apr 2019 10:53:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B1522086C for ; Mon, 1 Apr 2019 10:53:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H9R0F0RM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B1522086C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vUNGY9WIfbt62AMwW7D3hNsbuqE9pYSQ5bm//aYHlF0=; b=H9R0F0RM1lyhe8ELRDPiLZRL5 Af18kjiUcV64Mnbxs9Dp8KgYGBlpFkd4/ldl/3B5mtwUdq5kdFaBFoMrQeSLJL3QK+X7C3nnCbVpl rgv8NyPRa3DnrijveViN/k+zzNP64jZQ9n8mLrP3HEkJXQ1wgAI8dYZtHqgK8c+TX9mFao8HhhFjD WTi6xAzJt3LChCaptd8Uqdgy0iCPVZnWfbRCMGjTZ3sIJbJdOakdoCyxja2oQKJ3qdpzCZ0oXT4o+ 1EBYeoY9i2O2ddblTBWp6RY7RJfok43kQhk20k23fSbIP0fdwMJU/ytKyIA9zFjeGmqTwNUdPzh4b mJSW+6v3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAuYv-0005Xo-9e; Mon, 01 Apr 2019 10:53:09 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAuYs-0005XQ-3m for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 10:53:07 +0000 Received: from localhost (aaubervilliers-681-1-91-136.w90-88.abo.wanadoo.fr [90.88.32.136]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 5CCAA24000C; Mon, 1 Apr 2019 10:52:54 +0000 (UTC) Date: Mon, 1 Apr 2019 12:52:53 +0200 From: Maxime Ripard To: Rob Herring Subject: Re: [PATCH] dt-bindings: Add schemas for simple-framebuffer Message-ID: <20190401105253.oakh3uboz3vcgaj7@flea> References: <20190325135414.9728-1-maxime.ripard@bootlin.com> <20190326213526.w3t7fga7uzkkliq7@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_035306_303997_2835CCCF X-CRM114-Status: GOOD ( 25.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Maxime Jourdan , Bartlomiej Zolnierkiewicz , Hans de Goede , Chen-Yu Tsai , Frank Rowand , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: multipart/mixed; boundary="===============6240477670821120452==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6240477670821120452== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ver4pxryopk6mkpe" Content-Disposition: inline --ver4pxryopk6mkpe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Rob, On Wed, Mar 27, 2019 at 08:20:18AM -0500, Rob Herring wrote: > On Tue, Mar 26, 2019 at 4:35 PM Maxime Ripard wrote: > > On Mon, Mar 25, 2019 at 11:27:36AM -0500, Rob Herring wrote: > > > On Mon, Mar 25, 2019 at 8:54 AM Maxime Ripard wrote: > > > > > > > > The simple framebuffer is a binding that allows the bootloader to setup a > > > > framebuffer, describe it in the Device Tree for the OS to pick it up and > > > > use it as is. > > > > > > > > Replace the current binding by a schema to allow the validation tools to > > > > check those nodes. > > > > > > > > Cc: Bartlomiej Zolnierkiewicz > > > > Cc: Chen-Yu Tsai > > > > Cc: Hans de Goede > > > > Cc: Maxime Jourdan > > > > Signed-off-by: Maxime Ripard > > > > > > > > --- > > > > > > > > Rob, > > > > > > > > Even though the node itself is properly described, I still end up with some > > > > validation warnings when the chosen node is validated (basically > > > > complaining that ranges, and the framebuffer nodes shouldn't be here, since > > > > we haven't described them in the chosen schemas). > > > > > > Having 'ranges' is a bit strange because 'chosen' doesn't have an > > > address. We can add #address-cells, #size-cells and framebuffer child > > > node to the base chosen schema. I've just sent a github PR to do that. > > Maybe that's just cargo cult, but both the amlogic and the sunxi DT > > have ranges in chosen. Shouldn't we need it so that the address is > > decoded properly? > > I don't think so. If you have #{size,address}-cells then that should > be enough. Lack of ranges should just mean that any translation stops > at that level. But it is possible that the kernel code requires > translation to go all the way to the root for memory addresses. I > haven't checked. I tested it, and it looks like of_translate_address returns EINVAL if ranges is missing. If that's not desired, then I can look into it. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ver4pxryopk6mkpe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKHthQAKCRDj7w1vZxhR xbmUAQCTkmDrLqtWqobnC14Z6+AF71RCc1xM7mDnUCuVn1+P6gEA98D8TPwM+Agm mairFtF8LX6JqtsGj/rwbm38fl8eFAg= =/QXO -----END PGP SIGNATURE----- --ver4pxryopk6mkpe-- --===============6240477670821120452== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6240477670821120452==--