From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_DISCARD,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B2DCC43381 for ; Mon, 1 Apr 2019 11:34:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11B372084B for ; Mon, 1 Apr 2019 11:34:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jgvFTQ8S"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=megous.com header.i=@megous.com header.b="hAop2vP2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11B372084B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=megous.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+EBIxEXJg1n45WOykVcZ3/HyneuyCx4RYWk3pwGdYOI=; b=jgvFTQ8ShKzLcY Shx39WxsrA8Ckn6sSV3hGX0q8T8v6kj+NR9zt2JQRzstCeXTennkF4vt4RRaipZrzEN3NqTgZYCuP 09Y8z4MpAQmKjmv1KHaplXmuK99Nc/er08lJOWgrLqe0+bVa8z1Z+e7AbcGTOzuXXlopcOmVIko5j ikQASReWVO24DQqUdbpqbYssqXUq2bWBSxSxABSE5RZf6wdb9mvj5gxemLjygevmCp7InxzAHRIG4 /UmbtXRdLdSf42uAl6yYtCeHTivpBeY2GJs3ijBpSsJK4vMfcjve7M2s1ORv9ablfb1XfXhiuDhMk bIQuDBcWdesO5bfUWYfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAvD4-0007GO-6X; Mon, 01 Apr 2019 11:34:38 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAvD1-0007G4-Jz for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 11:34:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1554118474; bh=89FjOYUNqERl6OhtF0+u99Sl9W6d06HO2w/ZdVwXZYY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hAop2vP2dIbiWzv8DaZNR+3nn51Lt/JlfO9jou1YW9kCrUeMquNWclVaSdBV2RgRZ HRPSkPA7zWa+dCdUlba936NAM1REVoFUNGsu3vbyx4PO4I932qI+oTdwmKsPIxxb0L L5Ew2pBqgXdHEkj8R6OqNxwJ5JxcIgrSr849o9GU= Date: Mon, 1 Apr 2019 13:34:33 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Maxime Ripard Subject: Re: [PATCH 2/7] ARM: dts: sun8i: tbs-a711: Add node for BMA250 accelerometer Message-ID: <20190401113433.z2dps2s5vszt37n7@core.my.home> Mail-Followup-To: Maxime Ripard , wens@csie.org, robh@kernel.org, johan@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com References: <20190327001843.2420-1-megous@megous.com> <20190327001843.2420-3-megous@megous.com> <20190401063049.h2as3qllpelkxkbb@flea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190401063049.h2as3qllpelkxkbb@flea> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_043435_807922_12A3B308 X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, robh@kernel.org, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, johan@kernel.org, linux-kernel@vger.kernel.org, wens@csie.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Maxime, On Mon, Apr 01, 2019 at 08:30:49AM +0200, Maxime Ripard wrote: > Hi, > > On Wed, Mar 27, 2019 at 01:18:38AM +0100, megous@megous.com wrote: > > From: Ondrej Jirman > > > > A711 tablet has BMA250 accelerometer connected to I2C1 bus. Enable > > both the I2C1 bus and add the accelerometer device to it. > > > > Signed-off-by: Ondrej Jirman > > --- > > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > index 6aae70c89a1e..347fc0c31fa4 100644 > > --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > @@ -156,6 +156,21 @@ > > status = "okay"; > > }; > > > > +&i2c1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c1_pins>; > > It's there already I see, I'll drop it. Thanks. > > + clock-frequency = <400000>; > > + status = "okay"; > > + > > + /* Accelerometer */ > > + bma250@18 { > > The node name should be the class of the device, not its model, so > something like accelerometer. I'll rename this. thank you, Ondrej > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel