From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B36EDC43381 for ; Mon, 1 Apr 2019 14:44:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E3ED206C0 for ; Mon, 1 Apr 2019 14:44:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GxoCkIFP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E3ED206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2iWyE5JUgLRE8y/tC/lr+KBfmL+mkJ8KdodRAU3B1tg=; b=GxoCkIFPHqEdgC O7H/JPgwAxIfDe7RBONmgxjKVaf+wN0VvoSeU2KsiRCRC98hLT85n/+MuLDT/dBteAf5O7FHD4XFP D03lmj2ivt+TroEGiyZ5jqVFHGm+yc73Iw/otdSZQMV2ExmG6boZG66h+/MmxtU8zM7Y4tM06ZKoB 6rtiCVOrNbGRLMdPxA2NFR8b2enzZzUcHnDfTBjW1ez0FlaoMNOrRSBVnIqN6v5uNvy/qHmll5tbo xS5JSSGLIDguHxiORw8dctyqyb0J+appZzzCBfYkiHb/wMoRAUA9YZkkra7SJUY7FYlQ9s0jiN/LH qnj1MBkv0nlfERnaL9Tg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAyAN-0005xx-FB; Mon, 01 Apr 2019 14:44:03 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAyAK-0005x4-AU for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 14:44:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A9097A78; Mon, 1 Apr 2019 07:43:59 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 968883F690; Mon, 1 Apr 2019 07:43:58 -0700 (PDT) Date: Mon, 1 Apr 2019 15:43:56 +0100 From: Catalin Marinas To: Vincenzo Frascino Subject: Re: [PATCH 3/4] arm64: compat: Refactor aarch32_alloc_vdso_pages() Message-ID: <20190401144355.GI14874@arrakis.emea.arm.com> References: <20190401112025.40807-1-vincenzo.frascino@arm.com> <20190401112025.40807-4-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190401112025.40807-4-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_074400_367995_02338F77 X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Mark Rutland , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 01, 2019 at 12:20:24PM +0100, Vincenzo Frascino wrote: > +static int __init aarch32_alloc_vdso_pages(void) > +{ > + return aarch32_alloc_kuser_vdso_page() & > + aarch32_alloc_sigreturn_vdso_page(); > } > arch_initcall(aarch32_alloc_vdso_pages); It probably doesn't matter much but I'd rather not bit-and two error codes. Just return the non-zero one or pick the first (your choice) if both are wrong. (normally, if you want a non-zero random value if any of them failed, you'd use bit-or) -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel