From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3483C43381 for ; Mon, 1 Apr 2019 15:38:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A05B52133F for ; Mon, 1 Apr 2019 15:38:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AVv82Gzy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A05B52133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p0zfSooIvS6UhLHYhZgi89thhj3k/TfRvrawtNO2BSk=; b=AVv82GzyAvg89z 2w79z8hDeyaVO5TDoqZoKnXC4kh658OGBcThoyMZkiF5UEcJBSXm3IUuAxZEFbKOIRcfPPqh2Zool d6yKRR/LgMI9Yy+p0umurHXnGxMuCQABPKYdR7lCEkyyT1oWqDMfyKD0ge7NUPp8KpHXp10lZjn0I n7qWc5yr0kZytWAp7Xo7l2Evusm148/YLwKxNA44dLwaWMZBXojOsX1tPVpEGIUAYU6cfMTHmvYhf jJArwUREc9tDHlZ1Xx39DN6g+Q3J7GrGHy2t4Vu94XSibrot/KFn6OQ0M/d3ARBTEuH6qxXHF3f8l zmd8b74i/MHV3fgt14VQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAz0X-0006sj-Mi; Mon, 01 Apr 2019 15:37:57 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAz06-0006Ed-Mk for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 15:37:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 47324A78; Mon, 1 Apr 2019 08:37:28 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 36F043F690; Mon, 1 Apr 2019 08:37:27 -0700 (PDT) Date: Mon, 1 Apr 2019 16:37:22 +0100 From: Will Deacon To: Wen Yang Subject: Re: [PATCH v2 14/15] arm64: cpu_ops: fix a leaked reference by adding missing of_node_put Message-ID: <20190401153722.GA6884@fuggles.cambridge.arm.com> References: <1551785646-46173-1-git-send-email-wen.yang99@zte.com.cn> <1551785646-46173-14-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1551785646-46173-14-git-send-email-wen.yang99@zte.com.cn> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_083731_463953_B19C2DB8 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wang.yi59@zte.com.cn, Catalin Marinas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 05, 2019 at 07:34:05PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm64/kernel/cpu_ops.c:102:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 69, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang > Reviewed-by: Florian Fainelli > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > v2->v1: add a missing space between "adding" and "missing" > > arch/arm64/kernel/cpu_ops.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/cpu_ops.c b/arch/arm64/kernel/cpu_ops.c > index ea00124..00f8b86 100644 > --- a/arch/arm64/kernel/cpu_ops.c > +++ b/arch/arm64/kernel/cpu_ops.c > @@ -85,6 +85,7 @@ static const char *__init cpu_read_enable_method(int cpu) > pr_err("%pOF: missing enable-method property\n", > dn); > } > + of_node_put(dn); > } else { > enable_method = acpi_get_enable_method(cpu); > if (!enable_method) { Looks about right to me: Acked-by: Will Deacon How do you plan to get this upstream? Can we just pick this one up via arm64? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel