From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8372C43381 for ; Mon, 1 Apr 2019 17:52:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A83C20830 for ; Mon, 1 Apr 2019 17:52:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KPpkrZrY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A83C20830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=umkWijGPL7M8q/Dvl1MDf3y5IWyAhvKC8vJCtVRKONA=; b=KPpkrZrYH9Ff1Y UW1sA+KRCr4sMzR/ojk3lQSby7UzJiYaAUNehhJM9S9d8DQy5L++Uo4B8ksWjcA5es+r0GCPfuJz/ IwWp2DUV5b3UOLHNKYHXf+LmYqnW+ZaHL5+KGkQ7mr0vFLX16+dweqNAIvjJmt2D8w4ncpCF3resj iO/9TJoKmcZoDh6myDUyrecwM/CxgMIdI3DFHDZbJnAMdguQlg+sWwcSu3nfkqPXmMoGqcYA7fCvm Os/i96Od1xau1/jtQAnjhLaDTI4xxwMuXDM0+rnJEA3h5hrsaK/hHPJsLdwf7KpnoU/CzuJ07WqAG dNtguUOIpcm2RtM4pKeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB176-0004Sb-Bg; Mon, 01 Apr 2019 17:52:52 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB173-0004SC-MR for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 17:52:51 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 9D80080C0; Mon, 1 Apr 2019 17:53:02 +0000 (UTC) Date: Mon, 1 Apr 2019 10:52:45 -0700 From: Tony Lindgren To: Keerthy Subject: Re: [PATCH 3/5] arm: mach-omap2: pm33xx: Add support for rtc+ddr in self refresh mode Message-ID: <20190401175245.GJ49658@atomide.com> References: <20190322171619.4180-1-j-keerthy@ti.com> <20190322171619.4180-4-j-keerthy@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190322171619.4180-4-j-keerthy@ti.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_105249_779131_5BCB9025 X-CRM114-Status: GOOD ( 10.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@bootlin.com, d-gerlach@ti.com, t-kristo@ti.com, ssantosh@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, * Keerthy [190322 17:16]: > +static int am43xx_check_off_mode_enable(void) > +{ > + /* > + * Check for am437x-sk-evm which due to HW design cannot support > + * this mode reliably. > + */ > + if (of_machine_is_compatible("ti,am437x-sk-evm") && enable_off_mode) { > + pr_warn("WARNING: This platform does not support off-mode, entering DeepSleep suspend.\n"); > + return 0; > + } > + > + return enable_off_mode; > +} Considering off-mode suspend depends on how the board is wired for various things such as memory, PMIC and the related signal lines, I agree using the machine compatible is the best check we can do here. But since the device can hang during suspend unless things are configured right for the board, I suggest you rather list allowed boards here that are known to work with off-mode. Otherwise many out-of-tree boards might hang during suspend mysteriously. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel