From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA8DFC43381 for ; Mon, 1 Apr 2019 18:48:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76A2F2086C for ; Mon, 1 Apr 2019 18:48:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Glono1j5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76A2F2086C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CEM1EMC26lgiaQ2WS1SEbsRJVYBBaJT0QX8zcCaxoEE=; b=Glono1j5CM2bYw 43UKdKrQFPB9VgLk4Dw1ClF0vgPprtqq/aM7cQqNDaEsKqEYxrNHwA3HvJ8rklEFwvD6AoSwuym9s 9rlObWyYrHi4t5d3SutYF/CMmu0KFqRpOG7cZGFVof11JaMBSY8SBWPy9alYz8hGyCH+rrIWCiT8D zJK3nYdSXlez7HQbi7/JpQ9tUoIRCgTXMjyDq6tD0oUfNJc27NxoUSuEykwZFc1Wn8/CoauZeIPmA QN/j2jFWwX652K0j2BevEn+7jjMNJm476uIsPQUTEyO/Alg7iG4hLga+y4ZaiMRuIjWkoxk1SlYC1 hi45FSL3TndYhDYnsoLQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB1zG-00025Y-47; Mon, 01 Apr 2019 18:48:50 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB1zC-000252-9A for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 18:48:48 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 305F88044E; Mon, 1 Apr 2019 20:48:32 +0200 (CEST) Date: Mon, 1 Apr 2019 20:48:31 +0200 From: Sam Ravnborg To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Subject: Re: [PATCH 2/2] drm: Add ASPEED GFX driver Message-ID: <20190401184831.GA14599@ravnborg.org> References: <20190328054316.17939-1-joel@jms.id.au> <20190328054316.17939-3-joel@jms.id.au> <730c140f-b4a2-7df9-3d90-9d47d720f643@tronnes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <730c140f-b4a2-7df9-3d90-9d47d720f643@tronnes.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=9XS--2bQUGw2v4SV7EUA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_114846_499353_EC969DE0 X-CRM114-Status: GOOD ( 16.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Maxime Ripard , linux-aspeed@lists.ozlabs.org, David Airlie , dri-devel@lists.freedesktop.org, Andrew Jeffery , Rob Herring , Joel Stanley , Daniel Vetter , Sean Paul , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Joel. Replying to Noralf's mail as I lost the original mail. > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c b/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c > > new file mode 100644 > > index 000000000000..e2d1d7497352 > > --- /dev/null > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c > > @@ -0,0 +1,248 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +// Copyright 2018 IBM Corporation > > + > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > I prefer includes sorted alphabetically, but no requirement. Please sort them as Noralf suggest, as this makes it much more obvious when one is adding a duplicate header. > > + > > + priv->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL); > > + if (IS_ERR(priv->rst)) { > > + dev_err(&pdev->dev, > > + "missing or invalid reset controller device tree entry"); Add error code to your dev_err() calls, so one later better can tell what was wrong if river fails to load. Same goes for other dev_xxx calls in this function / dirver. (Most dev_xxx have the return code, only a few seems to miss it) > > +static const struct of_device_id aspeed_gfx_match[] = { > > + { .compatible = "aspeed,ast2400-gfx" }, > > + { .compatible = "aspeed,ast2500-gfx" }, > > + { } Many drivers put a /* sentinel */ comment inside the empty {} With the few things suggested above considered this is Reviewed-by: Sam Ravnborg Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel