From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E4DC43381 for ; Mon, 1 Apr 2019 18:39:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42DB5206C0 for ; Mon, 1 Apr 2019 18:39:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GcclLVbe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="DHk87esu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42DB5206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kemnade.info Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ngU2pJWPxR4BzmaIrAdKUuosqKE1HCWzh13B+55mB8c=; b=GcclLVbedbLTJURpRbwli9kQo YBJMaxenYDzlcXo5YF/1wggLSeI4/iMyxG9G/cyjhqrONA8OdT7GYGjCj+qag7MST34xnE9Y4o1t/ lAwEW9DzMxpvNTls1be4ZOSY0Wtamf852bB9XlDy82A6X46CjX+NMPzlUZaB617uPEnS29bqo5CvT koEOQ4MwMOzZ7Z1tNnV7AwhA2ivrr2i1RTqNcrUJrdHXz/yAaXiZcOaScc1RjXX5m0olI0/e9VXvD XMbUnXAD0wuG8KAVjj3jlxcvmFx3QVvVyjT9mxaC6B5h6g1Lheh8CTxUEurQdKI1dEUJLoguYNHXZ znLhDhU3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB1qA-0006XN-Bk; Mon, 01 Apr 2019 18:39:26 +0000 Received: from mail.andi.de1.cc ([2a01:238:43f3:0:615b:ee97:1f81:cbf2] helo=h2641619.stratoserver.net) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB1q5-0006WS-Di for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 18:39:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3xNH0yYZty3T1s/vvcIFXyS+J03hT8Dc3vigYtnAaf8=; b=DHk87esucdZU0gMRMB1eOOn85 uME0I6MFv596rOeS8L2BR0FqY9gzXyJfVHPg7irxwrbhml5lvUsRYXUNufFFdwVp5bys/fu1V0c7f 0hkuqXSG0XzOAXFB0j9lBHgV0xATsJcKquL+ReaSRj6RcD+PGnEs2SZM4ajKGWrSYKD50=; Received: from p200300ccfbcc5b007ee9d3fffe1fa246.dip0.t-ipconnect.de ([2003:cc:fbcc:5b00:7ee9:d3ff:fe1f:a246] helo=eeepc) by h2641619.stratoserver.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hB1pr-0006cP-Mp; Mon, 01 Apr 2019 20:39:07 +0200 Received: from [::1] (helo=localhost) by localhost with esmtp (Exim 4.89) (envelope-from ) id 1hB1pq-0002SY-Bd; Mon, 01 Apr 2019 20:39:06 +0200 Date: Mon, 1 Apr 2019 20:38:54 +0200 From: Andreas Kemnade To: Tony Lindgren Subject: Re: [PATCH 3/5] arm: mach-omap2: pm33xx: Add support for rtc+ddr in self refresh mode Message-ID: <20190401203854.3b6ec1a2@kemnade.info> In-Reply-To: <20190401175245.GJ49658@atomide.com> References: <20190322171619.4180-1-j-keerthy@ti.com> <20190322171619.4180-4-j-keerthy@ti.com> <20190401175245.GJ49658@atomide.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; i686-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_113921_767308_84B859B6 X-CRM114-Status: GOOD ( 14.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@bootlin.com, d-gerlach@ti.com, Keerthy , t-kristo@ti.com, ssantosh@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5330085055870608740==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5330085055870608740== Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/IM5.dslcLd5HSNhpIvRvxx2"; protocol="application/pgp-signature" --Sig_/IM5.dslcLd5HSNhpIvRvxx2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 1 Apr 2019 10:52:45 -0700 Tony Lindgren wrote: > Hi, >=20 > * Keerthy [190322 17:16]: > > +static int am43xx_check_off_mode_enable(void) > > +{ > > + /* > > + * Check for am437x-sk-evm which due to HW design cannot support > > + * this mode reliably. > > + */ > > + if (of_machine_is_compatible("ti,am437x-sk-evm") && enable_off_mode) { > > + pr_warn("WARNING: This platform does not support off-mode, entering = DeepSleep suspend.\n"); > > + return 0; > > + } > > + > > + return enable_off_mode; > > +} =20 >=20 > Considering off-mode suspend depends on how the board is > wired for various things such as memory, PMIC and the related > signal lines, I agree using the machine compatible is the best > check we can do here. >=20 > But since the device can hang during suspend unless things are > configured right for the board, I suggest you rather list allowed > boards here that are known to work with off-mode. >=20 Could we somehow describe this property of the hardware (is-offmode-capable or is-wired-for-offmode) as a separate devicetree property of the soc? In mmc we have for example "cap-power-off-card" for indicating some is-wired-suitable-for thing. That looks to be clearer as looking for some strange conditions derived from something. I have still my offmode patch os the boilerplate... Regards, Andreas --Sig_/IM5.dslcLd5HSNhpIvRvxx2 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEPIWxmAFyOaBcwCpFl4jFM1s/ye8FAlyiWr8ACgkQl4jFM1s/ ye/cGw//ZYvBpuTdIquv8gIi92U+KCQ40dhGuS4RS+ekk6hKriDB25jH+WPtBtYE CE5TP6wdEXzyDpuFmStNmcgHnSESuZphI9NWw6kNtkUXdzfiNh/wdoUnKzibY0UN pyezoSkhvnlU+7ss92sV2MjtOABSSMxpAiBtX4o/MifvWe5Z65RiqgprZ364Jxg/ GToGGzFosbcdk2eYR6aBl3F42J7ot0bD49W6JC8Pd08zSg2L1D9cb017IXEuxNF5 gsWRdoncV6wI62ZPPkwgJBc/6JcVLz6C+2Be2KbWkyYph23afNWcoIfqwLxjv4Dd Re7HkXnbeSnkUCVPIdAn/1bNVtiQGAVxsezmFuO9p1zTOt5nNYKzoPNyaYf5deau Kj+/xqP1anSyBGEo8pluIVXE35d3yy0NqP4Ct+PVf7hYt0OeEFE1dONTRED9BwDQ 9fIh/PvWVofyev4QeKaos0wBni1fXFKwAOtgAVKVCHFjkd163tCY+b71qaQRUQLn ZqKog7XJcnx91Zv8+YTNxczrvyio1asa0D/F07j7uQlIpoyfqxVCJ5y6nbPEi427 akwLclMYtTrj43+LCTkJMUZbJvGAwLwEKyMYq9K1l5tKM169OBS8e47jq0nnS/ut Lorje/wJEnfQRTby20aFKl3mXVBv9drIpbGt5JAtV5PoQandrL8= =B7hI -----END PGP SIGNATURE----- --Sig_/IM5.dslcLd5HSNhpIvRvxx2-- --===============5330085055870608740== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5330085055870608740==--