From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E93EC43381 for ; Mon, 1 Apr 2019 20:40:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1ABB20880 for ; Mon, 1 Apr 2019 20:40:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="auOXDY83" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1ABB20880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lG7kE2pIkcfsMz4vnKCyofabglqwiHcj94+IsQ4tYE4=; b=auOXDY834stkCR r/WcOagoJsyXEWOOuWhYE+rsx07LEtIsJpcezE1QsFSlENLFcla/Efeil3hvHgsvsZ7uM1dfJw11F T8c+40PaabEIBkOiCOUAkB/pMjzkpxQTznZ0TukWc1b3BwWVuPSU9QBadtjzZUC82xrG0jQwIu+6f VazZeE8YYoC5G2VRfTDrBJ65rZP681eilckR4nm0SwhCJDt2W8j3InsRUwvkPK/xNEG13Lz8AoAkB 5F07cRUV3FAuIZAzIyIMI+eA+1iDYluYXZ0Arq9a5V0X4OxAZ23eYUKAbMRdOvfKUvSe89/CHK4Tn s0mIVfJk7xoU0LLeD1Kg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB3jW-0008B1-EY; Mon, 01 Apr 2019 20:40:42 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB3jT-0008Ac-7J for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 20:40:40 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id BF58180C0; Mon, 1 Apr 2019 20:40:50 +0000 (UTC) Date: Mon, 1 Apr 2019 13:40:33 -0700 From: Tony Lindgren To: Andreas Kemnade Subject: Re: [PATCH 3/5] arm: mach-omap2: pm33xx: Add support for rtc+ddr in self refresh mode Message-ID: <20190401204033.GK49658@atomide.com> References: <20190322171619.4180-1-j-keerthy@ti.com> <20190322171619.4180-4-j-keerthy@ti.com> <20190401175245.GJ49658@atomide.com> <20190401203854.3b6ec1a2@kemnade.info> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190401203854.3b6ec1a2@kemnade.info> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_134039_304942_7448E8E3 X-CRM114-Status: GOOD ( 16.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@bootlin.com, d-gerlach@ti.com, Keerthy , t-kristo@ti.com, ssantosh@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Andreas Kemnade [190401 18:39]: > On Mon, 1 Apr 2019 10:52:45 -0700 > Tony Lindgren wrote: > > > Hi, > > > > * Keerthy [190322 17:16]: > > > +static int am43xx_check_off_mode_enable(void) > > > +{ > > > + /* > > > + * Check for am437x-sk-evm which due to HW design cannot support > > > + * this mode reliably. > > > + */ > > > + if (of_machine_is_compatible("ti,am437x-sk-evm") && enable_off_mode) { > > > + pr_warn("WARNING: This platform does not support off-mode, entering DeepSleep suspend.\n"); > > > + return 0; > > > + } > > > + > > > + return enable_off_mode; > > > +} > > > > Considering off-mode suspend depends on how the board is > > wired for various things such as memory, PMIC and the related > > signal lines, I agree using the machine compatible is the best > > check we can do here. > > > > But since the device can hang during suspend unless things are > > configured right for the board, I suggest you rather list allowed > > boards here that are known to work with off-mode. > > > Could we somehow describe this property of the hardware > (is-offmode-capable or is-wired-for-offmode) as a separate devicetree > property of the soc? > > In mmc we have for example "cap-power-off-card" for > indicating some is-wired-suitable-for thing. And we also have "regulator-off-in-suspend". How about "soc-off-in-suspend" for the generic name? > That looks to be clearer as looking for some strange conditions > derived from something. > > I have still my offmode patch os the boilerplate... Care to send a binding patch to devicetree@vger.kernel.org for that? And then when it gets acked, we can just start using it :) Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel