From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E98C6C43381 for ; Tue, 2 Apr 2019 06:26:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B888320840 for ; Tue, 2 Apr 2019 06:26:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KsI2IMl0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B888320840 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C54MJF0LHAGz8Ze/JVgh9ztQqK1/I/Wli/4VGXg4fxc=; b=KsI2IMl0L6JFlo 5OIA1IYr7mDyll//W/7aK4mJoUAi9AkYsT0a6dWLtVwqHsGkQPZQ81H+WuWD9P5xZ0MJ8i0xM6n1a LSXj9yxF0aZooabGKu1x/oEoxgYbeCdY4qnYQoLclWIkw6c7QOlx9qz+S6bxmtrthSbddqlGuDRLv Nckpc/MsPfvaqnIw2mgbWarPzV9uHXK83W8V/fJpw3hFNS8oZwGJ3f8dETd7ASuCNI9cHq3Ai15hU +m+nNdkb3u8P4INfT6bspl4ftnbEBzP1oUlxLfK2ILZw6RSxMw1j2ZTOzql5j+GyyNsWahdaFC8pV HXeb2zMznwWZAij2gJkg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBCs7-0005cE-Ux; Tue, 02 Apr 2019 06:26:11 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBCs4-0005bM-A9 for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2019 06:26:10 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id DD23D8042B; Tue, 2 Apr 2019 08:25:57 +0200 (CEST) Date: Tue, 2 Apr 2019 08:25:55 +0200 From: Sam Ravnborg To: Joel Stanley Subject: Re: [PATCH v2 2/3] drm: Add ASPEED GFX driver Message-ID: <20190402062555.GA14723@ravnborg.org> References: <20190402021933.13071-1-joel@jms.id.au> <20190402021933.13071-3-joel@jms.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190402021933.13071-3-joel@jms.id.au> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=WlVxpDaDHMoEeOP1qeUA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_232608_531592_CBAE3FAB X-CRM114-Status: GOOD ( 11.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Andrew Jeffery , Rob Herring , Daniel Vetter , Sean Paul , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Joel > index 000000000000..fb56e425bd48 > --- /dev/null > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > @@ -0,0 +1,104 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +// Copyright 2018 IBM Corporation > + > +#include > +#include A drmP.h include was left here, can we have this removed too. > + > +static struct drm_driver aspeed_gfx_driver = { > + .driver_features = DRIVER_GEM | DRIVER_MODESET | > + DRIVER_PRIME | DRIVER_ATOMIC | > + DRIVER_HAVE_IRQ, DRIVER_HAVE_IRQ is obsolete and not needed anymore. See drm_drv.h for details. With these few things fixed: Reviewed-by: Sam Ravnborg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel