From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3198FC4360F for ; Tue, 2 Apr 2019 13:31:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F36122133D for ; Tue, 2 Apr 2019 13:31:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RPxYgsA6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F36122133D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PxVpdJZPh+Fef/64Eqdb/+njGlAATXxKuVWXtNTwylM=; b=RPxYgsA6uBhAAe 3FQ87lA07rl+vSAby2TFYMSGMeH0d2YfKUi94/iTWtfTk0PUzrgzcmbQQaGayKe1PQJBt5tk/Trgh lOYToZkV8v0C0lGpK4HpEQvMi5QFDfI7ByYwH7l2Q+ssrfc3J6qHFo5XA6VvGM2AkUuaC0T64ISdr B1sHyIwMWTGhm4q2C8frnxF/JRNwhF/PYClZ0YErQpNQa0ykorToPI43461v6J2i+O6a5upYQCEWc isF8NGXVpvw33WKWxbbgyC7Y0rK7qcVO6LfTgfDvSFJ4ZuYpIrGoBCShL+sNleE9aXfI9wmSt5CZB dlwM89Gf0KKkHbyFRptg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBJVq-0005GM-0J; Tue, 02 Apr 2019 13:31:38 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBJVm-0005Fb-Up for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2019 13:31:36 +0000 Received: by mail-ot1-f65.google.com with SMTP id t8so11980420otp.7 for ; Tue, 02 Apr 2019 06:31:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iXmfkcg6xDIBfN/TTphCFGlH2CQvn3O0YGQqVKTVE/g=; b=WSiJT34P80+/8WMeiXVm1hMetsBEvP4FDDCc5puqW8lMRGCtU/TONi4YUVRTvJk7hD GJ7U/H6+G/YnB0SFUFnVuMHi+JJZa5bSdujKW65ZeXVj3MK6mK2jq93IdyQHFuv6w6Xc ecS/amAv571UBFjQnXKN/BB4YMSjRTbBif4NlznJRArdxWsyRSLqY2EAxbgHo8X0WFnc i/SGOL7NC7r91TDs5gQttuFVu/HsJTz8A8X+nmkg1azEB3dwnkXdJ0KI58e4ZdDzUrPD PdWJH9t9iIfMWH1NF/f4T7IUwh1fvD6m+RlAGutQkEW1eF94fpXnLEGOXXm+PredN6dK Qmyw== X-Gm-Message-State: APjAAAU0VVM5cvv6Mpp7nsAo8ZLf6LuBN1phn91d1Jkl6GKeS7nghVjo v5YsUXAFmdZbIlS5dYGlF4Y= X-Google-Smtp-Source: APXvYqyHaTg6OnFKF1QRQcxVpTWy4N4ZM7/nLP8m2ALIewnf2MTGZG4qvp+97g5W/sdDaYQvGQVGkw== X-Received: by 2002:a9d:7f03:: with SMTP id j3mr47241231otq.249.1554211891654; Tue, 02 Apr 2019 06:31:31 -0700 (PDT) Received: from localhost ([130.164.62.212]) by smtp.gmail.com with ESMTPSA id l5sm5637076otr.53.2019.04.02.06.31.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Apr 2019 06:31:31 -0700 (PDT) Date: Tue, 2 Apr 2019 06:31:30 -0700 From: Moritz Fischer To: Nava kishore Manne Subject: Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp Message-ID: <20190402133130.GA14646@archbook> References: <20190402123123.915-1-nava.manne@xilinx.com> <20190402123123.915-4-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190402123123.915-4-nava.manne@xilinx.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_063134_989710_B5211841 X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, atull@kernel.org, linux-fpga@vger.kernel.org, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, jollys@xilinx.com, rajanv@xilinx.com, robh+dt@kernel.org, mdf@kernel.org, linux-arm-kernel@lists.infradead.org, chinnikishore369@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nava, looks mostly good to me. One minor nit below: On Tue, Apr 02, 2019 at 06:01:23PM +0530, Nava kishore Manne wrote: [..] > diff --git a/drivers/fpga/zynqmp-fpga.c b/drivers/fpga/zynqmp-fpga.c > new file mode 100644 > index 000000000000..f6e35fe95adb > --- /dev/null > +++ b/drivers/fpga/zynqmp-fpga.c > @@ -0,0 +1,159 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2019 Xilinx, Inc. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +/* Constant Definitions */ > +#define IXR_FPGA_DONE_MASK 0X00000008U You could use the BIT(x) macro here. > + > +/** > + * struct zynqmp_fpga_priv - Private data structure > + * @dev: Device data structure > + * @flags: flags which is used to identify the bitfile type > + */ > +struct zynqmp_fpga_priv { > + struct device *dev; > + u32 flags; > +}; > + [..] Reviewed-by: Moritz Fischer Thanks, Moritz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel