From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD96C4360F for ; Tue, 2 Apr 2019 16:36:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 068452070B for ; Tue, 2 Apr 2019 16:36:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ctg46exz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 068452070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hWZQ93cmFq4HWPD0Oub+u9olxJdzxTWUxX2AwqHcfk8=; b=ctg46exzmzP8v5 47VKIf0K+Iznc9MNxhQlmnVfHcP7HcQ+mJ+MHMPK7C0LAK70mWYFV3xTbfxd0s0OFKWvxepgJp+IU mkCmoljAloLv2Sj98d4CX+ctWE0t+9j1RJbpuaiKZu/TKG/Qv+Yl2/sk9+03mZ22Df3mw0x5syz+Q F0/e3v3o3wBvLbDi2WWw1anOwVwElJiJqLu7JOTlmscge91KB3XsZUNaCQ+DDNX7N29L8fdY3Nu37 T0lLn9fSsZGm+2Kg72Db6V0x1V5cr1W7N4S5Q52MFhg8/6YdZ0WRq47NzwAg2GO2CNhothOQcu8T7 Sw2fdm/KU6qyqxskpTsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBMOO-0003vF-DV; Tue, 02 Apr 2019 16:36:08 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBMOM-0003up-7Y for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2019 16:36:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0742980D; Tue, 2 Apr 2019 09:36:06 -0700 (PDT) Received: from mbp (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1897C3F721; Tue, 2 Apr 2019 09:36:04 -0700 (PDT) Date: Tue, 2 Apr 2019 17:36:02 +0100 From: Catalin Marinas To: Vincenzo Frascino Subject: Re: [PATCH v3 3/4] arm64: compat: Refactor aarch32_alloc_vdso_pages() Message-ID: <20190402163602.4sjlwtkp73zyzpld@mbp> References: <20190402162757.13491-1-vincenzo.frascino@arm.com> <20190402162757.13491-4-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190402162757.13491-4-vincenzo.frascino@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_093606_288833_6E9BD319 X-CRM114-Status: GOOD ( 11.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 02, 2019 at 05:27:56PM +0100, Vincenzo Frascino wrote: > +static int __init aarch32_alloc_vdso_pages(void) > +{ > + int kuser_err, sigreturn_err; > + > + kuser_err = aarch32_alloc_kuser_vdso_page(); > + if (kuser_err) > + return kuser_err; > > - aarch32_vdso_pages[C_VECTORS] = virt_to_page(vdso_pages[C_VECTORS]); > - aarch32_vdso_pages[C_SIGPAGE] = virt_to_page(vdso_pages[C_SIGPAGE]); > + sigreturn_err = aarch32_alloc_sigreturn_vdso_page(); > + if (sigreturn_err) > + return sigreturn_err; > > return 0; Reviewed-by: Catalin Marinas (nitpick: could have used a single "err" variable; no need to re-spin) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel