From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 029DBC4360F for ; Wed, 3 Apr 2019 09:27:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6920206B7 for ; Wed, 3 Apr 2019 09:27:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OqyAkhCA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6920206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=j400ncgUa+eWy/tAazLlcTyAhdAqeW3DuEp8tLr/wxw=; b=OqyAkhCAoi3wZb4DvFYFE2x9i npAG+kFY9nLTImVafvr25dSdHKlFi/rjp+aW32Icyl0OIUqbCVW9Yoth75bELWJ2V2aqORETzyzJP BbfKu/IeGmFFmSwdRaQaZiODoLCKvpEmmGupvu++RQYNJc6QztLOlRlMyVsc8bQKATA+rZpVvXRHd cSUyIYVp7yiv5zEQ4lrb417tFCW62vbxq8sE4ULHegw0kAlTAocXWp2E210RDt5KJe6vxWzTgSyho FyLSZnk2OeUXhlxHqVYKdHxTGGlEoDMw2Sz3V7rWVhd5JpHgFcKK9YheJKPNQurLs16GgDXBfznC3 lndTZ6MoQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBcAo-00021m-Hr; Wed, 03 Apr 2019 09:27:10 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBcAj-0001zT-PI for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2019 09:27:08 +0000 X-Originating-IP: 90.88.30.125 Received: from localhost (aaubervilliers-681-1-89-125.w90-88.abo.wanadoo.fr [90.88.30.125]) (Authenticated sender: maxime.ripard@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 9E59824001B; Wed, 3 Apr 2019 09:26:55 +0000 (UTC) Date: Wed, 3 Apr 2019 11:26:55 +0200 From: Maxime Ripard To: Sakari Ailus Subject: Re: [PATCH v4 3/5] media: sunxi: Add A10 CSI driver Message-ID: <20190403092655.engthyfinpxvndh4@flea> References: <20190403091221.qd5ivgcoviazccv7@paasikivi.fi.intel.com> MIME-Version: 1.0 In-Reply-To: <20190403091221.qd5ivgcoviazccv7@paasikivi.fi.intel.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190403_022705_963823_90BFA914 X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Hans Verkuil , Laurent Pinchart , Thomas Petazzoni , Mauro Carvalho Chehab , Frank Rowand , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: multipart/mixed; boundary="===============2972042175811182661==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2972042175811182661== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zchbulmqh2lleyeb" Content-Disposition: inline --zchbulmqh2lleyeb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Sakari, On Wed, Apr 03, 2019 at 12:12:21PM +0300, Sakari Ailus wrote: > Thanks for the update and my apologies for the late review. > > On Tue, Mar 19, 2019 at 04:55:46PM +0100, Maxime Ripard wrote: > > The older CSI drivers have camera capture interface different from the one > > in the newer ones. > > > > This IP is pretty simple. Some variants (one controller out of two > > instances on some SoCs) have an ISP embedded, but there's no code that make > > use of it, so we ignored that part for now. > > > > Signed-off-by: Maxime Ripard > > Could you add a sub-device for the CSI-2 receiver, please? > > See e.g. drivers/media/pci/intel/ipu3/ipu3-cio2.c for an example. It's confusing, I know, but this isn't a MIPI-CSI receiver. The IP is called CSI, but it's only capable of handling parallel and BT656. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --zchbulmqh2lleyeb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKR8XwAKCRDj7w1vZxhR xWzTAQCO6onvJvAyxQ/6zEc/t+3ODQNIh2Kd0llgRcS0+j8TzgEA+9nsA6jNG3Rt 7u3CgLYRL2TexYqGU4lz12/2fB7ndAA= =riar -----END PGP SIGNATURE----- --zchbulmqh2lleyeb-- --===============2972042175811182661== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2972042175811182661==--