From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC7EC4360F for ; Wed, 3 Apr 2019 12:44:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B588A20830 for ; Wed, 3 Apr 2019 12:44:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dJRXQDoQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B588A20830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zew+bapRjvV/R41AIDGa/dvZWAoL5SpXl6gi6QTBJ9M=; b=dJRXQDoQfeAaFx YYY5HyggdN/K8gPANaJ454vLBMrQKZ1o/AmYeG4IaWjUzgNKRjOclE9hUd/Y8IQnn6cjpb61ZPH2p OqzKZ8+MQkOkAhgza3g1pm/boWbPEYka6DDrekPH4/JMzqPyfRYpB/xSft1patgSDrHJsuzdFds8w zQYhGOtwX8+3m+7mdpLgturHUdi7wiLKW/HhVZBQAeSWJf0abzPaYyTDINWa1BdLvlYTTl0fs8K3e QAAAIq32PyB6mntvrDUBKy8lUL9DqI/ad389mqg6pUS1F71JAOmHS8KkVq9pPufJj6VQOjuozb0C2 j7Xx/dovP1BEXx+Uz0iA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBfFu-0001KR-Dr; Wed, 03 Apr 2019 12:44:38 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBfFp-0001DY-A9 for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2019 12:44:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ADBBF15AD; Wed, 3 Apr 2019 05:44:32 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9E8ED3F59C; Wed, 3 Apr 2019 05:44:31 -0700 (PDT) Date: Wed, 3 Apr 2019 13:44:29 +0100 From: Will Deacon To: wen.yang99@zte.com.cn Subject: Re: =?utf-8?B?562U5aSNOiBSZTogW1BBVENIIHYy?= =?utf-8?Q?_14=2F15=5D_arm64=3A_cpu=5Fops?= =?utf-8?Q?=3A?= fix a leaked reference byadding missing of_node_put Message-ID: <20190403124429.GG16362@fuggles.cambridge.arm.com> References: <20190401153722.GA6884@fuggles.cambridge.arm.com> <201904031356099956278@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201904031356099956278@zte.com.cn> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190403_054433_893387_4AA8BA2C X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wang.yi59@zte.com.cn, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 03, 2019 at 01:56:09PM +0800, wen.yang99@zte.com.cn wrote: > > > The call to of_get_next_child returns a node pointer with refcount > > > incremented thus it must be explicitly decremented after the last > > > usage. > > > > > > Detected by coccinelle with the following warnings: > > > ./arch/arm64/kernel/cpu_ops.c:102:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 69, but without a corresponding object release within this function. > > > > > > Signed-off-by: Wen Yang > > > Reviewed-by: Florian Fainelli > > > Cc: Catalin Marinas > > > Cc: Will Deacon > > > Cc: linux-arm-kernel@lists.infradead.org > > > Cc: linux-kernel@vger.kernel.org > > > --- > > > v2->v1: add a missing space between "adding" and "missing" > > > > > > arch/arm64/kernel/cpu_ops.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/kernel/cpu_ops.c b/arch/arm64/kernel/cpu_ops.c > > > index ea00124..00f8b86 100644 > > > --- a/arch/arm64/kernel/cpu_ops.c > > > +++ b/arch/arm64/kernel/cpu_ops.c > > > @@ -85,6 +85,7 @@ static const char *__init cpu_read_enable_method(int cpu) > > > pr_err("%pOF: missing enable-method property\n", > > > dn); > > > } > > > + of_node_put(dn); > > > } else { > > > enable_method = acpi_get_enable_method(cpu); > > > if (!enable_method) { > > > > Looks about right to me: > > > > Acked-by: Will Deacon > > > > How do you plan to get this upstream? Can we just pick this one up via > > arm64? > > Ok, thank you. > We are very happy to know that it is useful. Ok, I picked it up. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel