From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 656F4C4360F for ; Wed, 3 Apr 2019 17:12:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F9CD2084B for ; Wed, 3 Apr 2019 17:12:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bO9na9Vt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F9CD2084B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5LPLLqUrQCVMP/I3xsEkikxS+RtkFEKleDB4yvVE+X8=; b=bO9na9VtUZ7C/K 7wBvDm55lDjg7KW8lKj99/c+V0+ITh4aWbgVKAzScalAlFVK8UUSf4afA3viIfQGXfmBVZ+e5oO8J 5iA4GKMv5sDwIlBgdV7592AX1By3PAaTpgrNvzoYNHBMh0UHcZMETan3mOncwaLvqAESXcFnINTuL rZnM7W0BitJZKjmEQI17IMeVsrnTvWIUa6bztCOllvI/P148MOm0tbKjnfbHH3o8w2YeJioVjSg8a 05bKHXSTudeT13azQG8u7hmLQEmAK8N+4rK+qLkwCmhsxhlUb4v2XKl1yBysMEwCdcBkohdyBmgv1 sHHoKD8ywvUAyLQzz0Vg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBjQj-0008OH-VS; Wed, 03 Apr 2019 17:12:05 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBjQg-0008Nq-Px for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2019 17:12:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6934780D; Wed, 3 Apr 2019 10:12:02 -0700 (PDT) Received: from red-moon (red-moon.cambridge.arm.com [10.1.197.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BFB693F68F; Wed, 3 Apr 2019 10:12:00 -0700 (PDT) Date: Wed, 3 Apr 2019 18:11:55 +0100 From: Lorenzo Pieralisi To: Kishon Vijay Abraham I , Gustavo Pimentel Subject: Re: [PATCH v5 0/8] PCI: DWC/Keystone: MSI configuration cleanup Message-ID: <20190403171154.GA3783@red-moon> References: <20190321095927.7058-1-kishon@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190321095927.7058-1-kishon@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190403_101202_847184_75843E9D X-CRM114-Status: GOOD ( 21.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Murali Karicheri , Jingoo Han , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 21, 2019 at 03:29:19PM +0530, Kishon Vijay Abraham I wrote: > This series tries to address the comments discussed in [1] w.r.t > removing Keystone specific callbacks defined in dw_pcie_host_ops. > > This series also tries to cleanup the Keystone interrupt handling > part. > > Changes from v4: > *) Removed legacy interrupt cleanup patch which uses hierarchy IRQ > domain since TI platform uses edge interrupt for legacy interrupt. > This will be deferred till I get more details from HW team. > > Changes from v3: > *) Uses hierarchy IRQ domain for legacy interrupts since there is 1:1 > mapping between legacy interrupt and GIC IRQ. > (MSI still depends on the order of IRQs populated in dt). > > Changes from v2: > *) Removed patch that modifies ks_pcie_legacy_irq_handler() to check the > IRQ_STATUS of INTA/B/C/D. Lorenzo's comment to create a matrix > LinuxIRQ x INTx will be added in AM654x PCIe support series > *) ks_pcie_legacy_irq_handler() is made to use hwirq to get IRQ offset > instead of virq. > *) default msi_irq_chip is assigned in dw_pcie_host_init() once keystone > assigns its msi_irq_chip > *) Fixed other minor comments from Lorenzo and Bjorn > > Changes from v1: > *) Removed "PCI: keystone: Use "dummy_irq_chip" instead of new irqchip > for legacy interrupt handling" from the patch series. It should be > handled differently. > > *) Added Gustavo's ACKed by and fixed a commit message. > > [1] -> https://patchwork.kernel.org/patch/10681587/ > > Kishon Vijay Abraham I (8): > PCI: keystone: Cleanup interrupt related macros > PCI: keystone: Add separate functions for configuring MSI and legacy > interrupt > PCI: keystone: Use hwirq to get the MSI IRQ number offset > PCI: keystone: Cleanup ks_pcie_msi_irq_handler > PCI: dwc: Add support to use non default msi_irq_chip > PCI: keystone: Use Keystone specific msi_irq_chip > PCI: dwc: Remove Keystone specific dw_pcie_host_ops > PCI: dwc: Do not write to MSI control registers if the platform > doesn't use it > > drivers/pci/controller/dwc/pci-keystone.c | 365 ++++++++++-------- > .../pci/controller/dwc/pcie-designware-host.c | 78 ++-- > drivers/pci/controller/dwc/pcie-designware.h | 6 +- > 3 files changed, 233 insertions(+), 216 deletions(-) I would need Gustavo's ACKs on dwc patches, I will queue the series then. Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel