From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD545C4360F for ; Wed, 3 Apr 2019 18:37:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C1C32133D for ; Wed, 3 Apr 2019 18:37:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oFPXGSqa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C1C32133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+qRs5A1qsGYvnuYgRz+9t6TQr5PJlt9QEsNqmaA1YXg=; b=oFPXGSqaKD47S2xMbSgjPw/Na spwZwcVmxY8ZJwu9yb8JAptSnw8EWbZ63KumhxzQQobnlB2uVswkWojao3gSWDAzovC+TH87kQf1+ oYUQqSO7Qpgs/j0mYhwqQ69x66GIpQE1t2OXXPGDosOLCd7WMsduHnsbTJKXVFukSKsBPID1twhuw kLfful8nF4+6A7YUdK3seDprWbiTRrv+xvt85mVIPplcxW43pjnf8BeDTZwHIyyqPPt9e3BxUoGx7 xJrMHQVJ+xPPoMv4S4RGYfzIwpHmwp4yxHH5iXRdiWFdUL0c2dYkm6nvsLwinOE4EN4O/M8hRq8QP FMhh9YPhg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBkkv-0001Ga-2a; Wed, 03 Apr 2019 18:37:01 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBkks-0001GF-1a for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2019 18:36:59 +0000 X-Originating-IP: 90.89.68.76 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (Authenticated sender: maxime.ripard@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 6EA38FF802; Wed, 3 Apr 2019 18:36:45 +0000 (UTC) Date: Wed, 3 Apr 2019 20:36:44 +0200 From: Maxime Ripard To: Linus Walleij Subject: Re: [PATCH 1/6] gpio: Set proper argument value to set_config Message-ID: <20190403183644.b25rlkxgquw2aqny@flea> References: MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190403_113658_230732_A9E1D37F X-CRM114-Status: GOOD ( 18.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartosz Golaszewski , Chen-Yu Tsai , Thomas Petazzoni , Linux ARM , "open list:GPIO SUBSYSTEM" Content-Type: multipart/mixed; boundary="===============1946750626100144879==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1946750626100144879== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xzcfhjrw3mhb4ztv" Content-Disposition: inline --xzcfhjrw3mhb4ztv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Linus, On Wed, Apr 03, 2019 at 11:41:02PM +0700, Linus Walleij wrote: > On Fri, Mar 15, 2019 at 2:33 AM Maxime Ripard wrote: > > > The gpio_set_config function creates a pinconf configuration for a given > > pinc_config_param. > > > > However, it always uses an arg of 0, which might not be a valid argument > > for a given param. A good example of that would be the bias parameters, > > where 0 means that the pull up or down resistor is null, and the pin is > > directly connected to VCC/GND. > > > > The framework uses in some other places the value 1 as a default argument > > to enable the pull resistor, so let's use the same one here. > > > > Signed-off-by: Maxime Ripard > > Patch applied to the GPIO tree, I suppose I can merge it there > orthogonally to the other patches (the result will be fine). Yeah, the only drawback I can see is that the configuration will be rejected, but since it's going to be merged in fixes, the case where we have the driver patches but not that one seems pretty unlikely. We have a lot going through our tree for the next release though, so ideally we should merge the DT patches through arm-soc. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --xzcfhjrw3mhb4ztv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKT9PAAKCRDj7w1vZxhR xcHFAP4vu4p3UO+zfOA/jHxHN1yFkMq7Uf6RazHs6Qfs4/l3zQD8CnB/TVXMhTeT TTwxfNIF/T2X3kNrEhz0kKViBz6fEAs= =m/Gq -----END PGP SIGNATURE----- --xzcfhjrw3mhb4ztv-- --===============1946750626100144879== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1946750626100144879==--