From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB25C4360F for ; Fri, 5 Apr 2019 00:20:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE49620663 for ; Fri, 5 Apr 2019 00:20:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HdttJdBJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE49620663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: From:Subject:To:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Wsw3iFLBR4LyQ5Y8fDBhUKhP+5RR4kaGFTJ8RhI0Jc=; b=HdttJdBJQbUIy7 XzPHX4L/cnzMlRLvJXeloz5MJQAdfAB9MWS77UiLH37DYSIUgBMOYiatOtwJDqHmE+I3s98wzBoDf +UVGSGBfB/QywMABW2Ig5LETWciLJuR6NXNBbTVp5SKc5K/3qLEPdN6bXZ7sA8O/dWJtbNMtJrYfJ 4QlPJ+Mc2YwXiCMHCz2JzjO7vpwKKfCd/xJuobk9OweyutwoTB/JgJNGyI97BW569GFoq6AbHGQMu DXNmE24C3goaRGvs4r13N9UJDS7hdyIn36Td2paEaqYk3reLr8E7afT9JKilqFCtVYJ2kvFVCDLxw Fzf4/Mf0N1JX9rXSKEvg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCCb6-0000qC-Cr; Fri, 05 Apr 2019 00:20:44 +0000 Received: from shards.monkeyblade.net ([2620:137:e000::1:9]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCCb3-0000pt-M6 for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2019 00:20:42 +0000 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CFFEA14737689; Thu, 4 Apr 2019 17:20:39 -0700 (PDT) Date: Thu, 04 Apr 2019 17:20:39 -0700 (PDT) Message-Id: <20190404.172039.1083206882112207747.davem@davemloft.net> To: mcroce@redhat.com Subject: Re: [PATCH net] net: thunderx: don't allow jumbo frames with XDP From: David Miller In-Reply-To: <20190402231136.15156-1-mcroce@redhat.com> References: <20190402231136.15156-1-mcroce@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 04 Apr 2019 17:20:40 -0700 (PDT) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190404_172041_725900_EF976B15 X-CRM114-Status: UNSURE ( 8.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, sgoutham@cavium.com, rric@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Matteo Croce Date: Wed, 3 Apr 2019 01:11:36 +0200 > The thunderx driver forbids to load an eBPF program if the MTU is higher > than 1500 bytes, but this can be circumvented by first loading the eBPF, > and then raising the MTU. > > XDP assumes that SKBs are linear and fit in a single page, this can lead > to undefined behaviours. > Fix this by limiting the MTU to 1500 bytes if an eBPF program is loaded. > > Fixes: 05c773f52b96e ("net: thunderx: Add basic XDP support") > Signed-off-by: Matteo Croce Please respond to Jesper's feedback about your choice of a limit of 1500. Otherwise I will toss your patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel