From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F92C4360F for ; Thu, 4 Apr 2019 10:23:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4299720882 for ; Thu, 4 Apr 2019 10:23:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YBpxkqlC"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cX6vmRXV"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="bVzr0GTW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4299720882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Message-Id:To:References: In-Reply-To:From:Subject:MIME-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0+kM15SBK8/7dLk/QaLM8ZlDzAwol1aBCBO6ik1tJDM=; b=YBpxkqlC7kaOrL s2VB6fuQsTmIFbUfaGKDJXeqCOVjldOX2rAF4cONhWnfkrS4N4KznS80VpnfeRf1XkbD54Qa3kFAI hjt4Q0JsWpUEmJ4pIV5Nv4sPMPUBhB1UnFDjdPmShZgAjjGiZPS5F7LdUWpvsigRc7N9n3QVfePAn 6VEBGYXkwd+3ehZecVxNbvKcI9LJYk8kXvwdpbvg2IPRBTW4vA8NahS4/oHKNHYgAJPpOgZ1ot79x R75zu5DXjf8soAeWoezYgXUuTTOGarSD8HlQVPhbFzXOQXcqVfYBTHbjXFhtCdoaK07L0Zi325JNI cpJxPUfd97pQAkthQfew==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBzWI-0006Ia-L5; Thu, 04 Apr 2019 10:22:54 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBzWF-0006I0-Fb; Thu, 04 Apr 2019 10:22:52 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0C5FA60A43; Thu, 4 Apr 2019 10:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554373371; bh=yWDs5V/rHVkCiJE/mrmVvDr5bxI4I/D6hGIib6vKu/4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=cX6vmRXVQWkf0crFjApIZ9sULZ7aI92LLdIeeba17gBTCD8RBr1wfEqkXR4K2Dmu0 AxtFmaJTUJCsUrhg5NUVoZ9arL+xw8/ZivTW2FPlnlCF5zDtLigVal2PvKywpLGJy6 dNtVtQ/kBbf+byi50FrlH/nf1Ukm1Afln+IJoVp8= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4614961A40; Thu, 4 Apr 2019 10:22:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554373369; bh=yWDs5V/rHVkCiJE/mrmVvDr5bxI4I/D6hGIib6vKu/4=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=bVzr0GTWEy8dVpvNEF3LPNd72NxfYutWV3rmWhi44yCWbMgpBXv/WH/37fbVHVsR8 Pba1TWSNslrrhaKi1cQHkVr78AV7ee0BNLsJuVNpSgLSuyRS5jIou+FX4+40uj/dc0 wa4pocrDto3pzlJHeke0sUyIxq9YrgQosD9e8UF4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4614961A40 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org MIME-Version: 1.0 Subject: Re: [PATCH 3/4] mwifiex: Flag wake-up interrupt as IRQ_NOAUTOEN rather than disabling it too late From: Kalle Valo In-Reply-To: <20190224140426.3267-4-marc.zyngier@arm.com> References: <20190224140426.3267-4-marc.zyngier@arm.com> To: Marc Zyngier User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190404102251.0C5FA60A43@smtp.codeaurora.org> Date: Thu, 4 Apr 2019 10:22:50 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190404_032251_554676_45E02482 X-CRM114-Status: GOOD ( 10.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ganapathi Bhat , Heiko Stuebner , devicetree@vger.kernel.org, Xinming Hu , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Amitkumar Karwar , linux-rockchip@lists.infradead.org, Nishant Sarmukadam , Rob Herring , Enric Balletbo i Serra , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Marc Zyngier wrote: > The mwifiex driver makes unsafe assumptions about the state of the > wake-up interrupt. It requests it and only then disable it. Of > course, the interrupt may be screaming for whatever reason at that > time, and the handler will then be called without the interrupt > having been registered with the PM/wakeup subsystem. Oops. > > The right way to handle this kind of situation is to flag the > interrupt with IRQ_NOAUTOEN before requesting it. It will then > stay disabled until someone (the wake-up subsystem) enables it. > > Signed-off-by: Marc Zyngier > Reviewed-by: Brian Norris Failed to apply: fatal: sha1 information is lacking or useless (drivers/net/wireless/marvell/mwifiex/main.c). error: could not build fake ancestor Applying: mwifiex: Flag wake-up interrupt as IRQ_NOAUTOEN rather than disabling it too late Patch failed at 0001 mwifiex: Flag wake-up interrupt as IRQ_NOAUTOEN rather than disabling it too late The copy of the patch that failed is found in: .git/rebase-apply/patch Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/10827971/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel