From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 218B2C4360F for ; Thu, 4 Apr 2019 15:01:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6BBE2064A for ; Thu, 4 Apr 2019 15:01:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d1DNMn9v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6BBE2064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7MqEm1OLs2QPZ/ZH8vFBMW/vOcozo9oLwMlIxt5GXFE=; b=d1DNMn9vu58/II FMLZn03GMdg2Zrx2JLoOF+5NEsT0O6WCJUTZKdGznSIEfHfa/kKjd8/TR25V3VuRZTEj/Ymt+ED39 YrGWdPh56d5HAZ7H6ywUPl9WwPVjiq3kePsRtwBx62bjPmJPwmo66g7GIA0Qg2deFu4cehAXx134F icdv5FNhLg3CmhZc3HHWdRqXBwnNN7f4sey19NHflmUg2SEScaQhTRHNJwR9OlrVrOqG1RpmhXtO7 5xVCPpRETTuVneFYCrM24zep7q6ixxTgiKNsutTiPdePuaOWv6ml05qPmCPYdvyHXSuHrTdUPc5P6 3U7J9byzcs9pDD2esM7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hC3rz-00064y-Ni; Thu, 04 Apr 2019 15:01:35 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hC3rh-0005m4-FG for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2019 15:01:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB22D169E; Thu, 4 Apr 2019 08:01:16 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CED283F59C; Thu, 4 Apr 2019 08:01:15 -0700 (PDT) Date: Thu, 4 Apr 2019 16:01:13 +0100 From: Will Deacon To: Catalin Marinas Subject: Re: [PATCH v3 4/4] arm64: compat: Add KUSER_HELPERS config option Message-ID: <20190404150113.GB25912@fuggles.cambridge.arm.com> References: <20190402162757.13491-1-vincenzo.frascino@arm.com> <20190402162757.13491-5-vincenzo.frascino@arm.com> <20190404100847.GB43584@arrakis.emea.arm.com> <20190404145123.GL43584@arrakis.emea.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190404145123.GL43584@arrakis.emea.arm.com> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190404_080117_512966_4367BAD3 X-CRM114-Status: GOOD ( 17.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Vincenzo Frascino , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 04, 2019 at 03:51:23PM +0100, Catalin Marinas wrote: > On Thu, Apr 04, 2019 at 03:07:43PM +0100, Vincenzo Frascino wrote: > > On 04/04/2019 11:08, Catalin Marinas wrote: > > > diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h > > > index 228af56ece48..fcd0e691b1ea 100644 > > > --- a/arch/arm64/include/asm/processor.h > > > +++ b/arch/arm64/include/asm/processor.h > > > @@ -57,7 +57,7 @@ > > > #define TASK_SIZE_64 (UL(1) << vabits_user) > > > > > > #ifdef CONFIG_COMPAT > > > -#ifdef CONFIG_ARM64_64K_PAGES > > > +#if defined(CONFIG_ARM64_64K_PAGES) && defined(CONFIG_KUSER_HELPERS) > > > /* > > > * With CONFIG_ARM64_64K_PAGES enabled, the last page is occupied > > > * by the compat vectors page. > > > > > > > I agree, this change is required when the new config option is added. Do you > > want me to send an additional patch or will this be folded with the existing series? > > Folding it into patch 4/4 would be best but our arm64 for-next/core is > based on -rc3 and the TASK_SIZE_32 reduction didn't go in yet: > > https://lore.kernel.org/linux-arm-kernel/20190401113014.20866-1-vincenzo.frascino@arm.com/ > > I can drop the TASK_SIZE_32 patch from for-next/fixes (arguably, it's > not a regression and we cc stable anyway) and Will can merge it before > this series. Otherwise, the fixup above can go in at 5.2-rc1. > > Will, any preference? Agreed on taking this via for-next/core instead of fixes. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel