From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A776AC10F0C for ; Thu, 4 Apr 2019 16:33:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F2712171F for ; Thu, 4 Apr 2019 16:33:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WNzLXU4a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F2712171F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ENQeVzrqjmQyN3aVbkHh7MJWHfqFoYs78O1Y9L0kNO0=; b=WNzLXU4ac11/Qr hjfRqazM9WLBLifL8PCvAQt8tQEU5vUyxquQAN2T50Cllqavqj/doiZkG8AMQxOEsOycK3HECEpQz 3vOkXRvE8DM6f72QNJFa0vuLozGjwcGKcwhfujbRaoABOrhBu9LjwQPkvq32yfkU0WY5WrfivJtIJ zhle0Up2qQLc0ukTQQL8+h/toOylPhhrSUvXV12mAwWlYrd4nWTSx8JpyD9tJvgQYYlTHMUrxOUQM H0VlNPWERIsWTioDwnEEHOUj9Qg3+nSV24n8XaVcUBzROM7tn/c1wGZcgQz9g4sxu7R5DUQ3QOMRv JZ3Ls4v9hpY6NL4Sus1A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hC5Ij-0001p1-7b; Thu, 04 Apr 2019 16:33:17 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hC5If-0001oI-LZ for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2019 16:33:15 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 499E9C049E24; Thu, 4 Apr 2019 16:33:13 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB8A75C224; Thu, 4 Apr 2019 16:33:10 +0000 (UTC) Date: Thu, 4 Apr 2019 18:33:08 +0200 From: Andrew Jones To: Dave Martin Subject: Re: [PATCH v7 21/27] KVM: arm/arm64: Add hook for arch-specific KVM initialisation Message-ID: <20190404163308.2aaauxituh6rfffu@kamzik.brq.redhat.com> References: <1553864452-15080-1-git-send-email-Dave.Martin@arm.com> <1553864452-15080-22-git-send-email-Dave.Martin@arm.com> <20190404142528.pxo3vrnk6mfsgmyq@kamzik.brq.redhat.com> <20190404145354.GG3567@e103592.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190404145354.GG3567@e103592.cambridge.arm.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 04 Apr 2019 16:33:13 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190404_093313_741610_0CF87CBB X-CRM114-Status: GOOD ( 26.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Okamoto Takayuki , Christoffer Dall , Ard Biesheuvel , Marc Zyngier , Catalin Marinas , Will Deacon , Zhang Lei , Julien Grall , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 04, 2019 at 03:53:55PM +0100, Dave Martin wrote: > On Thu, Apr 04, 2019 at 04:25:28PM +0200, Andrew Jones wrote: > > On Fri, Mar 29, 2019 at 01:00:46PM +0000, Dave Martin wrote: > > > This patch adds a kvm_arm_init_arch_resources() hook to perform > > > subarch-specific initialisation when starting up KVM. > > > > > > This will be used in a subsequent patch for global SVE-related > > > setup on arm64. > > > > > > No functional change. > > > > > > Signed-off-by: Dave Martin > > > Reviewed-by: Julien Thierry > > > Tested-by: zhang.lei > > > --- > > > arch/arm/include/asm/kvm_host.h | 2 ++ > > > arch/arm64/include/asm/kvm_host.h | 2 ++ > > > virt/kvm/arm/arm.c | 4 ++++ > > > 3 files changed, 8 insertions(+) > > > > > > diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h > > > index 770d732..a49ee01 100644 > > > --- a/arch/arm/include/asm/kvm_host.h > > > +++ b/arch/arm/include/asm/kvm_host.h > > > @@ -53,6 +53,8 @@ > > > > > > DECLARE_STATIC_KEY_FALSE(userspace_irqchip_in_use); > > > > > > +static inline int kvm_arm_init_arch_resources(void) { return 0; } > > > + > > > u32 *kvm_vcpu_reg(struct kvm_vcpu *vcpu, u8 reg_num, u32 mode); > > > int __attribute_const__ kvm_target_cpu(void); > > > int kvm_reset_vcpu(struct kvm_vcpu *vcpu); > > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > > index 205438a..3e89509 100644 > > > --- a/arch/arm64/include/asm/kvm_host.h > > > +++ b/arch/arm64/include/asm/kvm_host.h > > > @@ -58,6 +58,8 @@ > > > > > > DECLARE_STATIC_KEY_FALSE(userspace_irqchip_in_use); > > > > > > +static inline int kvm_arm_init_arch_resources(void) { return 0; } > > > + > > > int __attribute_const__ kvm_target_cpu(void); > > > int kvm_reset_vcpu(struct kvm_vcpu *vcpu); > > > int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext); > > > diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c > > > index 99c3738..c69e137 100644 > > > --- a/virt/kvm/arm/arm.c > > > +++ b/virt/kvm/arm/arm.c > > > @@ -1664,6 +1664,10 @@ int kvm_arch_init(void *opaque) > > > if (err) > > > return err; > > > > > > + err = kvm_arm_init_arch_resources(); > > > + if (err) > > > + return err; > > > + > > > if (!in_hyp_mode) { > > > err = init_hyp_mode(); > > > if (err) > > > -- > > > 2.1.4 > > > > > > > It's not clear to me from the commit message why init_common_resources() > > won't work for this. Maybe it'll be more clear as I continue the review. > > init_common_resources() is for stuff common to arm and arm64. Well currently init_common_resources() only calls kvm_set_ipa_limit(), which isn't implemented for arm. So if there was a plan to only use that function for init that actually does something on both, it doesn't. > > kvm_arm_init_arch_resources() is intended for stuff specific to the > particular arch backend. I'm not sure we need that yet. We just need an arm setup sve stub like arm's kvm_set_ipa_limit() stub. OTOH, if we have to keep adding stubs to arm we should probably have something like kvm_arm_init_arch_resources() instead, and kvm_set_ipa_limit() should be moved inside the arm64 one and the arm ipa limit stub can go. Then since init_common_resources() would no longer be used, it could just be deleted. > > Maybe there is a better name for this. > The name is fine for me. Thanks, drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel