From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77264C4360F for ; Fri, 5 Apr 2019 09:13:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45224217D7 for ; Fri, 5 Apr 2019 09:13:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a4aPAsYn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45224217D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RroKlF79JJmtrtEPHVP25c1pkdq9+5V7eu56qHsg0W8=; b=a4aPAsYnhWnUGFAcGxVKFtNAw LUYJygD8QgcPVMasR7UPxmQGCCqebzOsk3m5Et5uNgK1bSJOh47xwackE15Bcf8EbozHkDbIvTgZ+ IQzdFjXFqTpdycq+rFoyjFFZ76WDaxPSyXw2idNz2uxnDrZckpTrnkc4n5vypWPbViR1gNP7ih1f3 8r9gkO75IgCje67OoGpj5gBSLysq8BCAw4G3QCRqFM+eKh2o3i0EGY3pSMMDKJaAdPG3+msAEEAiF Pu6DwSgW/+VxkbFq3z1uAOTCowpQyjXjxJR7XSKzvc24pmdqjU86Ve5fgjIpblnlDLnA+YfLvb5gq fzj0a6qYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCKuN-0007rR-4G; Fri, 05 Apr 2019 09:13:11 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCKuJ-0007qm-Az; Fri, 05 Apr 2019 09:13:09 +0000 X-Originating-IP: 90.88.30.125 Received: from localhost (aaubervilliers-681-1-89-125.w90-88.abo.wanadoo.fr [90.88.30.125]) (Authenticated sender: maxime.ripard@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id DBE1A20006; Fri, 5 Apr 2019 09:13:02 +0000 (UTC) Date: Fri, 5 Apr 2019 11:13:02 +0200 From: Maxime Ripard To: Miquel Raynal Subject: Re: [PATCH 1/3] dt-bindings: mtd: sunxi: Add new compatible Message-ID: <20190405091302.mz3gox5jvoy3ygjr@flea> References: <20190404162111.22618-1-miquel.raynal@bootlin.com> <20190404162111.22618-2-miquel.raynal@bootlin.com> MIME-Version: 1.0 In-Reply-To: <20190404162111.22618-2-miquel.raynal@bootlin.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190405_021307_527782_DB87C66A X-CRM114-Status: GOOD ( 20.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , Marek Vasut , Chen-Yu Tsai , Rob Herring , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2867152221007077147==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2867152221007077147== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n5ypdkjqsjaubm4k" Content-Disposition: inline --n5ypdkjqsjaubm4k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Thu, Apr 04, 2019 at 06:21:09PM +0200, Miquel Raynal wrote: > The A33 NAND controller is slightly different than the A10+ ones, > eg. DMA handling is a bit different and a few register offsets > changed. > > Introduce a new compatible to represent this version of the IP. > > Also append '-controller' to the new compatible (which is required for > new compatibles) as this is describing a NAND controller and not a > NAND chip. Out of curiosity, why are you requiring that suffix now? > Signed-off-by: Miquel Raynal > --- > Documentation/devicetree/bindings/mtd/sunxi-nand.txt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/sunxi-nand.txt b/Documentation/devicetree/bindings/mtd/sunxi-nand.txt > index dcd5a5d80dc0..6128d41d8c59 100644 > --- a/Documentation/devicetree/bindings/mtd/sunxi-nand.txt > +++ b/Documentation/devicetree/bindings/mtd/sunxi-nand.txt > @@ -1,7 +1,12 @@ > Allwinner NAND Flash Controller (NFC) > > Required properties: > -- compatible : "allwinner,sun4i-a10-nand". > +- compatible : Must be one of: > + - "allwinner,sun4i-a10-nand" > + - "allwinner,sun8i-a33-nand-controller" > + The former may be used by all IPs, however sun8i family > + will need the second one in order to make use of the > + internal DMA capabilities. I'm not sure we should have that statement. We have no idea whether or not this can be used by all IPs *today*, and we surely don't know about the one that are going to come out. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --n5ypdkjqsjaubm4k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKccHgAKCRDj7w1vZxhR xa80AQCcHxhF219b8x6s7hM0Ssg6zRuiugU4hDaSXzomyl/k1gD9EAt1ela1CmX7 bglrHBGB+HKxRtLtyx5bUWp7SecAoA4= =c303 -----END PGP SIGNATURE----- --n5ypdkjqsjaubm4k-- --===============2867152221007077147== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2867152221007077147==--