From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: stefan.wahren@i2se.com, devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
phil@raspberrypi.org, linux-kernel@vger.kernel.org,
eric@anholt.net, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] Revert "staging: vchiq_2835_arm: quit using custom down_interruptible()"
Date: Fri, 5 Apr 2019 15:02:17 +0300 [thread overview]
Message-ID: <20190405120217.GP32590@kadam> (raw)
In-Reply-To: <20190405113423.14495-2-nsaenzjulienne@suse.de>
On Fri, Apr 05, 2019 at 01:34:20PM +0200, Nicolas Saenz Julienne wrote:
> This reverts commit ff5979ad86368425b7da3a25f4e84650b51ff5fd.
> ---
Git kind of sets you up for failure with reverts...
Fix the subject, add a commit message and a Signed off by etc. We need
all the regular stuff. See commit 75ae193626de ("dm: revert
8f50e358153d ("dm: limit the max bio size as BIO_MAX_PAGES *
PAGE_SIZE")") for an example of how to do it nicely.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-05 12:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 11:34 [PATCH 0/3] staging: vchiq: use interruptible waits Nicolas Saenz Julienne
2019-04-05 11:34 ` [PATCH 1/3] Revert "staging: vchiq_2835_arm: quit using custom down_interruptible()" Nicolas Saenz Julienne
2019-04-05 12:02 ` Dan Carpenter [this message]
2019-04-05 12:22 ` Nicolas Saenz Julienne
2019-04-05 11:34 ` [PATCH 2/3] Revert "staging: vchiq: switch to wait_for_completion_killable" Nicolas Saenz Julienne
2019-04-05 11:34 ` [PATCH 3/3] staging: vchiq: make wait events interruptible Nicolas Saenz Julienne
2019-04-05 12:46 ` Stefan Wahren
2019-04-05 12:40 ` [PATCH 0/3] staging: vchiq: use interruptible waits Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405120217.GP32590@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox