Re: [PATCH 0/2] arm64: perf: Expose Cortex-A53 micro architectural events

Florian Fainelli
2019-04-05T16:15:14Z

On 4/5/19 5:36 AM, Jiri Olsa wrote:
> On Fri, Apr 05, 2019 at 10:36:20AM +0100, Robin Murphy wrote:
>> Hi Florian,
>>
>> On 05/04/2019 00:25, Florian Fainelli wrote:
>>> Hi all,
>>>
>>> This patch series adds support for the Cortex-A53 micro architectural
>>> events that I recently had to use for some debugging exercise.
>>>
>>> Events from 0xC0 - 0xD2 are exposed, others could easily be added later
>>> if we wanted to.
>>
>> As far as I'm aware (which admittedly is not all-the-way far) these events
>> should already be understood by userspace, per
>> tools/perf/pmu-events/arch/arm64/arm/cortex-a53/* - is there a specific
>> reason to need in-kernel definitions?
>
> right, we store events in perf tools in json files, please
> check commits changelogs under tools/perf/pmu-events/arch

Whoops, indeed no reason for making them part of the kernel, I will
investigate why the build system did not copy those files and update
them as necessary, thanks both for your feedback.
--
Florian