From: Will Deacon <will.deacon@arm.com>
To: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: marc.zyngier@arm.com, catalin.marinas@arm.com,
dave.martin@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] arm64: Use defines instead of magic numbers
Date: Fri, 5 Apr 2019 13:41:36 +0100 [thread overview]
Message-ID: <20190405124136.GA3100@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <1554459612-7354-1-git-send-email-alexandru.elisei@arm.com>
On Fri, Apr 05, 2019 at 11:20:12AM +0100, Alexandru Elisei wrote:
> Following assembly code is not trivial; make it slightly easier to read by
> replacing some of the magic numbers with the defines which are already
> present in sysreg.h.
>
> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
> ---
> arch/arm64/include/asm/assembler.h | 4 ++--
> arch/arm64/kernel/head.S | 10 +++++-----
> 2 files changed, 7 insertions(+), 7 deletions(-)
How dare you make our early assembly code easier to understand! This brings
us one step closer to being replaced by robots... which can't come soon
enough.
Applied for 5.2.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-05 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 10:20 [PATCH 1/1] arm64: Use defines instead of magic numbers Alexandru Elisei
2019-04-05 11:07 ` Dave Martin
2019-04-05 12:41 ` Will Deacon [this message]
2019-04-05 14:10 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405124136.GA3100@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dave.martin@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).