From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1C8AC4360F for ; Fri, 5 Apr 2019 12:47:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD85520700 for ; Fri, 5 Apr 2019 12:47:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JWeqxh3w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD85520700 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cam9xnFGujBW7Od8S4wyxF6k5ihhZZ2c09WvVM9eSvI=; b=JWeqxh3wjSp0wPap0CQuMfmqI zaKt8Vscn2pbgZ7ulcRzKbpYhzompXdbx29YXvZ4BLREZi5FjXdYRDaJwYTsuaTrXkejYpFD4un53 IgDcvqWqexYSzQxXm+10SsAx3p9hcM6DELwf/j5hwUJXIE56sF1v+l8Stsa6ojBWe9/HmRrcI1jMU 8OCue1GqIiv9VBFrvJKANU91ppl7rxv/nEwj/vNGgHAXFM8qSOjJHFLyjmKRYMDrmWqyhABmmgu5u XK7OCgm1/s69oVuic7QOX0GBR3unFe6cSJfFRc1bcYVG5c5vPZuKhTpnIlQEGZrjbzNZa/aVF9Zkl MKKlnUWMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCOFi-0001LK-CS; Fri, 05 Apr 2019 12:47:26 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCOFa-000191-W2; Fri, 05 Apr 2019 12:47:23 +0000 X-Originating-IP: 90.88.30.125 Received: from localhost (aaubervilliers-681-1-89-125.w90-88.abo.wanadoo.fr [90.88.30.125]) (Authenticated sender: maxime.ripard@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id B9C85240006; Fri, 5 Apr 2019 12:47:10 +0000 (UTC) Date: Fri, 5 Apr 2019 14:47:10 +0200 From: Maxime Ripard To: Miquel Raynal Subject: Re: [PATCH 2/3] mtd: rawnand: sunxi: Add DMA support for sun8i Message-ID: <20190405124710.ydsvbdwmhdirkssu@flea> References: <20190404162111.22618-1-miquel.raynal@bootlin.com> <20190404162111.22618-3-miquel.raynal@bootlin.com> <20190405091607.2dzckvyqibs7xmew@flea> <20190405113742.184234ca@xps13> <20190405105559.sqdhoa54ne7l4svj@flea> <20190405142554.44e3da68@xps13> MIME-Version: 1.0 In-Reply-To: <20190405142554.44e3da68@xps13> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190405_054719_980816_4B23BA51 X-CRM114-Status: GOOD ( 26.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , Marek Vasut , Chen-Yu Tsai , Rob Herring , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2090324502132887959==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2090324502132887959== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2ezg7hokwsr42x7c" Content-Disposition: inline --2ezg7hokwsr42x7c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 05, 2019 at 02:25:54PM +0200, Miquel Raynal wrote: > Hi Maxime, > > Maxime Ripard wrote on Fri, 5 Apr 2019 > 12:55:59 +0200: > > > On Fri, Apr 05, 2019 at 11:37:42AM +0200, Miquel Raynal wrote: > > > Hi Maxime, > > > > > > Maxime Ripard wrote on Fri, 5 Apr 2019 > > > 11:16:07 +0200: > > > > > > > On Thu, Apr 04, 2019 at 06:21:10PM +0200, Miquel Raynal wrote: > > > > > Allwinner NAND controllers can make use of DMA to enhance the I/O > > > > > throughput thanks to ECC pipelining. DMA handling with sun8i NAND IP > > > > > is a bit different than with the older SoCs, hence the introduction of > > > > > a new compatible to handle: > > > > > * the differences between register offsets, > > > > > * the burst length change from 4 to minimum 8, > > > > > * drive SRAM accesses through the AHB bus instead of the MBUS. > > > > > > > > > > Signed-off-by: Miquel Raynal > > > > > --- > > > > > drivers/mtd/nand/raw/sunxi_nand.c | 75 ++++++++++++++++++++++++++++--- > > > > > 1 file changed, 68 insertions(+), 7 deletions(-) > > > > > > > > > > diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c > > > > > index 4282bc477761..49cd5067adaa 100644 > > > > > --- a/drivers/mtd/nand/raw/sunxi_nand.c > > > > > +++ b/drivers/mtd/nand/raw/sunxi_nand.c > > > > > @@ -42,7 +42,8 @@ > > > > > #define NFC_REG_CMD 0x0024 > > > > > #define NFC_REG_RCMD_SET 0x0028 > > > > > #define NFC_REG_WCMD_SET 0x002C > > > > > -#define NFC_REG_IO_DATA 0x0030 > > > > > +#define NFC_REG_A10_IO_DATA 0x0030 > > > > > +#define NFC_REG_A33_IO_DATA 0x0300 > > > > > #define NFC_REG_ECC_CTL 0x0034 > > > > > #define NFC_REG_ECC_ST 0x0038 > > > > > #define NFC_REG_DEBUG 0x003C > > > > > @@ -200,6 +201,22 @@ static inline struct sunxi_nand_chip *to_sunxi_nand(struct nand_chip *nand) > > > > > return container_of(nand, struct sunxi_nand_chip, nand); > > > > > } > > > > > > > > > > +/* > > > > > + * NAND Controller capabilities structure: stores NAND controller capabilities > > > > > + * for distinction between compatible strings. > > > > > + * > > > > > + * @sram_through_ahb: On A33, we choose to access the internal RAM through AHB > > > > > + * instead of MBUS (less configuration). A10+ use the MBUS > > > > > > > > What do you mean by A10+ ? > > > > > > I meant A1x, A2x SoCs. Not sure it matches a product line for you, so > > > please suggest something to mean "SoCs which are not A33" (so far I > > > think all worked without this). > > > > The list is pretty small, so we can just name them. That would be the > > A10, A10s A13 and A20. > > You really need a "A10+"-like acronym for these ;) A10, A10s, A13, A20 and GR8 but not A23, A31, A33, A64, A80, A83t, or any SoC that is still not out yet. A10+ doesn't look like the most appropriate fit for that list :) Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --2ezg7hokwsr42x7c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKdOTgAKCRDj7w1vZxhR xVudAQCuuBo4cUMlYpc/L9/XqCL1JgdDSdvM7USvJj88SlJyKgEAnn8vc1GQRpPi F+zE4Wn8ipxtE58MCbyCEx7+360LLg4= =uozU -----END PGP SIGNATURE----- --2ezg7hokwsr42x7c-- --===============2090324502132887959== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2090324502132887959==--