From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6868C4360F for ; Fri, 5 Apr 2019 15:03:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3A61217D4 for ; Fri, 5 Apr 2019 15:03:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JnDX6ZcM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3A61217D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KG+erjv4vgpJWXrcj/6sGsGpxlJctpsurxXokGoMzEI=; b=JnDX6ZcMVAAewq 9BDNnIR3fwkhEFKpNM5eZhmONXvoQ4n13roKMZvZEX3nTcs1dTGbS1g7pfa0Cdn43dIKhOKBkV2oo ERRpsMyn8sIc+eqX4eV1tMlj//FneDtCf2VWYtH8/+/fm1AZu8vr02Ux4zkQ1gw8K0VhElLlkLw7S IwhQBDMd9mz2gCZ1nECeFmXEs3ZRvimHQHJurhtttHJ/ftOtjEFrMNe80LxOBrLyk3Ef/sbMYhqKG kIufp3zER8Lw+immMmioc3DzFdGDg8XNk+qzwevC6656MAlp6FQjqiM9Ah1fsrWs0eJOTFRetGJOl RqfZ0MbtXOyzCQjvfHxg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCQNO-0004hs-6f; Fri, 05 Apr 2019 15:03:30 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCQNK-0004hP-UC for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2019 15:03:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4EA0B16A3; Fri, 5 Apr 2019 08:03:26 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D36F93F68F; Fri, 5 Apr 2019 08:03:23 -0700 (PDT) Date: Fri, 5 Apr 2019 16:03:19 +0100 From: Will Deacon To: Zhi Li Subject: Re: [PATCH V4 2/4] drivers/perf: imx_ddr: Add ddr performance counter support Message-ID: <20190405150319.GA7704@fuggles.cambridge.arm.com> References: <1550253761-26841-1-git-send-email-Frank.Li@nxp.com> <1550253761-26841-2-git-send-email-Frank.Li@nxp.com> <20190404111714.GA26392@fuggles.cambridge.arm.com> <20190405143846.GB7313@fuggles.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190405_080326_973812_2418CBC9 X-CRM114-Status: GOOD ( 17.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , Aisheng Dong , "devicetree@vger.kernel.org" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , Frank Li , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 05, 2019 at 09:58:38AM -0500, Zhi Li wrote: > On Fri, Apr 5, 2019 at 9:38 AM Will Deacon wrote: > > On Fri, Apr 05, 2019 at 09:34:38AM -0500, Zhi Li wrote: > > > On Thu, Apr 4, 2019 at 6:17 AM Will Deacon wrote: > > > > On Fri, Feb 15, 2019 at 06:03:11PM +0000, Frank Li wrote: > > > > > Add ddr performance monitor support for iMX8QXP > > > > > > > > > > There are 4 counters for ddr perfomance events. > > > > > counter 0 is dedicated for cycles. > > > > > you choose any up to 3 no cycles events. > > > > > > > > > > for example: > > > > > > > > > > perf stat -a -e ddr0/read-access/,ddr0/write-access/,ddr0/precharge/ ls > > > > > perf stat -a -e ddr0/cycles/,ddr0/read-access/,ddr0/write-access/ ls > > > > > > > > Could you elaborate a bit on DDR_CAP_AXI_ID, please? Specifically, how > > Only imx845 have AXID filter capability now. > > > > > does the COUNTER_DPCR1 register work and what happens if I specify two > > > > simultaneous events with different values in config1? I'm a little wary > > There are difference match register for each event. > 1. Read event with config 1 A > 2. Read event with config 1 B > > 1 will show read count with filter A > 2 will show read count with filter B. Thanks, that makes sense, but I can't see how that corresponds to the code in the patch: +static void ddr_perf_event_start(struct perf_event *event, int flags) +{ + struct ddr_pmu *pmu = to_ddr_pmu(event->pmu); + struct hw_perf_event *hwc = &event->hw; + int counter = hwc->idx; + + if (pmu->flags & DDR_CAP_AXI_ID) { + if (event->attr.config == EVENT_AXI_READ || + event->attr.config == EVENT_AXI_WRITE) { + int val = event->attr.config1; + + writel(val, pmu->base + COUNTER_DPCR1); + } + } + + local64_set(&hwc->prev_count, 0); + + ddr_perf_event_enable(pmu, event->attr.config, counter, true); ddr_perf_event_enable() does what you'd expect, and uses hwc->idx to allocate a counter, but the code before it just always writes to DPCR1. What am I missing? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel