From: Olof Johansson <olof@lixom.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
arm@kernel.org, Nathan Chancellor <natechancellor@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: iop: don't use using 64-bit DMA masks
Date: Sun, 7 Apr 2019 15:20:12 -0700 [thread overview]
Message-ID: <20190407222012.cqbo64w6mmtdfr6i@localhost> (raw)
In-Reply-To: <20190325155101.3544731-2-arnd@arndb.de>
On Mon, Mar 25, 2019 at 04:50:43PM +0100, Arnd Bergmann wrote:
> clang warns about statically defined DMA masks from the DMA_BIT_MASK
> macro with length 64:
>
> arch/arm/mach-iop13xx/setup.c:303:35: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
> static u64 iop13xx_adma_dmamask = DMA_BIT_MASK(64);
> ^~~~~~~~~~~~~~~~
> include/linux/dma-mapping.h:141:54: note: expanded from macro 'DMA_BIT_MASK'
> #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
> ^ ~~~
>
> The ones in iop shouldn't really be 64 bit masks, so changing them
> to what the driver can support avoids the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to fixes.
-Olof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-07 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 15:50 [PATCH 1/2] ARM: orion: don't use using 64-bit DMA masks Arnd Bergmann
2019-03-25 15:50 ` [PATCH 2/2] ARM: iop: " Arnd Bergmann
2019-04-07 22:20 ` Olof Johansson [this message]
2019-04-07 22:20 ` [PATCH 1/2] ARM: orion: " Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190407222012.cqbo64w6mmtdfr6i@localhost \
--to=olof@lixom.net \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).