From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91B91C10F0E for ; Mon, 8 Apr 2019 02:38:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 634A920883 for ; Mon, 8 Apr 2019 02:38:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N7z1iMy4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SPn2RGmu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 634A920883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2cKklqlLeKNnSeRnt4mq/WEOKdxwH9Nl9Da9R+HxDHQ=; b=N7z1iMy4tMs7db q9phN8VxxWJXMUhhOwCeM5rbIEVIww2rf5aZbOah8MkaFsHmxUitFcbblhCCtHCIGLE/6Cb4B7Rme xqCq702f5JJibOR7S2AKvMP6XdQNdHd2qYAdmPJkioJVqv2xNWd5/rhlWcwM+LwcgoPzwiHWqGu21 HCHlkcIcgavrGrD+QKLO1GWu7L2i8Hyr3Sq104z1/ZqQBrHP5B8OTfmvmQNAcyR2ZSpW7r2OO4PiO 2UXT8RXuNBMdbqGGFdPXW6dADHVGxsHm0jkSTxXCdjzI2kBk1eofZTtIc8go/fQB9YMQ0UvSzUNL/ v7vQ497g22uHWK0IxnrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDKB1-0004mu-DH; Mon, 08 Apr 2019 02:38:27 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDKAx-0004lG-Cs; Mon, 08 Apr 2019 02:38:25 +0000 Received: by mail-pl1-x641.google.com with SMTP id t16so6423421plo.0; Sun, 07 Apr 2019 19:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QOaiSBgUtrP0Nzu2mhtUPDrwnQAuQijJq3uBYzp7jUg=; b=SPn2RGmucLcowteNtPbB6ju3RXN/MQx71KdkgACuJk3jR7eMPgkfm01zbQOCD+5MFU 2UlVd0rbQjpcW/ei1121Zo7igrmYNLRq60x2wGChsb4msnL5EFqLnh9/ONNjLGMi3g9S hKyJ2psOA9yfFo2VDXcj08IJk6tffgh02ymDeGgxGRGIp2BS1LhcIwqQ31lwIjggP8l1 +yxfr3Kk3WwzEmZppK/K2ykCkN4wwlZ7kIXEHdTilSJL98KxPDw7nslXm21jZ3zvJL9q LFBK9pXr+oZfAh+nuPXTRbrYIPyUKabGzxjdvuvquKPQThcAeQ6caXJjFlAqoQuAyD15 BT+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QOaiSBgUtrP0Nzu2mhtUPDrwnQAuQijJq3uBYzp7jUg=; b=k0f34jFZ1XWiO5cfCHWtf5H5KTb8eYGAMO+kfIbWUkwVxh9pcCEa3FuS4YrtWABk3L X1ohRt9cv46UuWRjtZLjPdH8KcERfW9NU571xNAEpU6vtyeUg9S155161zQQSVwUFp4j HVbj8tpJ9AuayMvrpm4gdbbz+bK9me3xEbZGT/C+TLplXtfdLPgJDHocAPzin2wkqZaW E74S0UvKs6Jdab/ACfHQhPb50PIwnAe6yDcymNCHGWunIjHruwJ45aqQUeXvhhxqGOQK CR5rHxkYXSSaWlOJCpYmooD6HzjU/K5U3n9BCLTeBXzyec0KT2u01QvsS0wck6ijmJdX k3JA== X-Gm-Message-State: APjAAAXfE6sdgeUmhNW2wKsEzypzDeqPq24nYQfn/CNIxO44LXArhwag 6XdL0BeF+WM/cP02kC9hQKo= X-Google-Smtp-Source: APXvYqyzgX1FtBsH1D512UipzE0fo3E21n34ZkbMvGPySLSYBL8njdqr0gmQEEeexM0VTLpdZ5uHNg== X-Received: by 2002:a17:902:2e83:: with SMTP id r3mr27515390plb.153.1554691101990; Sun, 07 Apr 2019 19:38:21 -0700 (PDT) Received: from localhost (c-73-222-71-142.hsd1.ca.comcast.net. [73.222.71.142]) by smtp.gmail.com with ESMTPSA id f63sm42265732pfc.180.2019.04.07.19.38.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Apr 2019 19:38:21 -0700 (PDT) Date: Sun, 7 Apr 2019 19:38:18 -0700 From: Richard Cochran To: Heiner Kallweit Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection Message-ID: <20190408023818.lmwxtjcqju7p7i7f@localhost> References: <0cc96fab-e102-c0d1-ade0-90e3e06dc9f1@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0cc96fab-e102-c0d1-ade0-90e3e06dc9f1@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190407_193823_464809_DAF9744B X-CRM114-Status: GOOD ( 10.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Florian Fainelli , Heiko Stuebner , Scott Branden , Kevin Hilman , linux-rockchip@lists.infradead.org, netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Ray Jui , linux-amlogic@lists.infradead.org, David Miller , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Apr 07, 2019 at 11:57:13AM +0200, Heiner Kallweit wrote: > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all Famous last words! > supported PHY's, at least for the ones with basic features sets, i.e. > PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these > features explicitly and rely on phylib feature detection. > > I don't have access to most of these PHY's, therefore I'd appreciate > regression testing. How about testing first, then merging? I suggest breaking this out into individual patches that can be Tested-by. Thanks, Richard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel