From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66262C10F14 for ; Mon, 8 Apr 2019 10:21:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3633520880 for ; Mon, 8 Apr 2019 10:21:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LXPnRBWJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Dxarpl8c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3633520880 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2f57ai3xuX0+xOpbNdUGtH4MJtPBkVAc3FMz5Xfnxa4=; b=LXPnRBWJHW9cTV f2XtrQxNmLu5jc8+DKm3NEhUlQk6wOQVe3ogjSN/ckZGtvZWX/nQj6ly+HJy7c7n6KX6mYzz3jl6c tZUVl1Xat4sx6HxZibkuk0NtbZBTS2JYzow4HyCPPBDjlKwOyenw3lQd2ztPSfsTfxIN+DmnGY48Q EvpKMAl+m46B+SxRPbsLv+IjiKa5hRp6DjipQCXKbfYCl8RISarYb5Iv3dVV15HtD2BXvcudtMaVZ 8La1H01XMxBdDTHgfc16pYGq6wU/noS67NJil0k2Bl+vd2VnfQwSCoGX6gVbP0fzb53jkgcAI1ha8 Az5foti34vZF76zhxieQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDRPH-0005Gq-Nw; Mon, 08 Apr 2019 10:21:39 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDRPF-0005GR-Cx for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2019 10:21:38 +0000 Received: by mail-pf1-x442.google.com with SMTP id b3so7373512pfd.1 for ; Mon, 08 Apr 2019 03:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=W13ir/3O4kQtJcvEFgEzE8M84aMPh80E8shkyCcmrhQ=; b=Dxarpl8cgx29GxFDAS7SxpwcLQbKg2Dvp5vG4HrT/fFafnmk60oLfcKJOEIE5EVkNw /pYz772fK4UHJtey7FtWuEgzsLLfqIP+Irmx52pk/+kw7d+W+OyH8m/3jpvGzqgXbzhI 9KMvgZxEuWvOYhX3NbfbE+SN1GNW+Y39VW7hOTf5SQ6NGp8XhZxDlswvaWQGeVXP4e+0 ufpcz4JA3T6jwsJIhi0eEs1cC1yXYBygYfAgYnAcLOY6RMVdusUPyCp0xGuOVLUhCL4c 2LVqOXosi5ArfN9fBFpD/8BxyxrbmQ7jNJVloqTXaQFBC1SRlhJLu0vAo1OUq/pdQIZo Sy8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=W13ir/3O4kQtJcvEFgEzE8M84aMPh80E8shkyCcmrhQ=; b=kNvn0564dFHQkMWioLsLrEqJj7YYqDP5Vu78q9aJniNDM+PbXqQLvPHlB9DE9dj2G8 4KYvce5ORxDZfh6py5gM64Wl+0oj1NQzIHeqV4aq/+G7eiWR2czpR8G+yWWoo1EARSRZ 2MMvV8VaR6b/ipdS5K4fxDU5OF3g4n88/gl+TQ+EF+5LqOxaXq1yqn8XngyyFj5XbULe dWuKp7NKkLmcRk+achVVjFHS5qXpKyh296HqfKmmWAKfVsmLU13gNFKV4qTHY76KfqHU waU/0wYC2ZSRyUzsiHTLn32a5XzE6hwMUCVL4Al8bO8AXM4Jq9EULXUJ0pzNo59m1Q3z rKag== X-Gm-Message-State: APjAAAVoShbv/4pku8U82SFcxNYX8j7Eymxy/xS7ZRxCgEWxZETAQcMR nzEip7cBkC7z6E5an5P3inRQDg== X-Google-Smtp-Source: APXvYqwxFhnB9dPeuD10c50fkcf9nVu79YtQWcFipFxNi82iB6EkKf96TBdBleIVJDB3DsmI2uEh3A== X-Received: by 2002:a62:5582:: with SMTP id j124mr29254633pfb.53.1554718896145; Mon, 08 Apr 2019 03:21:36 -0700 (PDT) Received: from localhost ([122.172.162.162]) by smtp.gmail.com with ESMTPSA id l192sm14128086pge.42.2019.04.08.03.21.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Apr 2019 03:21:34 -0700 (PDT) Date: Mon, 8 Apr 2019 15:51:32 +0530 From: Viresh Kumar To: Wen Yang Subject: Re: [PATCH 1/7] cpufreq: ap806: fix possible object reference leak Message-ID: <20190408102132.jeuulxxwkyvbppdp@vireshk-i7> References: <1554082674-2049-1-git-send-email-wen.yang99@zte.com.cn> <1554082674-2049-2-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1554082674-2049-2-git-send-email-wen.yang99@zte.com.cn> User-Agent: NeoMutt/20180323-120-3dd1ac X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_032137_470054_A065126F X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wang.yi59@zte.com.cn, Andrew Lunn , Jason Cooper , linux-pm@vger.kernel.org, Gregory Clement , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01-04-19, 09:37, Wen Yang wrote: > The call to of_find_compatible_node returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./drivers/cpufreq/armada-8k-cpufreq.c:187:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 130, but without a corresponding object release within this function. > ./drivers/cpufreq/armada-8k-cpufreq.c:191:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 130, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Gregory Clement > Cc: Sebastian Hesselbarth > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/cpufreq/armada-8k-cpufreq.c | 1 + > 1 file changed, 1 insertion(+) I haven't received the cover-letter and patch 4/7 (because the tags in that commit were incorrect). I have applied all the 7 patches to my cpufreq tree though. Thanks. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel