From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F25C10F13 for ; Mon, 8 Apr 2019 10:42:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D656620883 for ; Mon, 8 Apr 2019 10:42:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QYA0wWcw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D656620883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ouzfAGx6eDfy0AojlafNeRATCgSovUqj2jAQexLitXw=; b=QYA0wWcwPWQan2AQMRbeQ+OSs bSnJhPR5G0/NdTjFdYORA+Jiqr1KwKLedES2QhQufvFHyfz8vvcdNOXreY8afTBUAUGWJ3crFBjUj YRhA34SIiNd4mg8L9JIgVSTLQmuEo1NAUqdlwRTjQm4ySY1YZe/rZvyKx+BWbc7rFUitXvL8Lby0t Rzu0PA24L+LdCmaxkgoAhu245UxDPzDim156Hz+GpR6JxUVTJTJEinQDUlap/JiLeB1bXU6Ya0PtE Yyt83iZG/3NisbzuWHMRm51Qz4O2ctug+1KsqKxiJmBrBvaBY3C8bo4t5e7DQAAcD12ly0rvcqdYc MeMf8+xhg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDRjA-00053l-Kg; Mon, 08 Apr 2019 10:42:12 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDRj6-00052v-98 for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2019 10:42:10 +0000 Received: from localhost (aaubervilliers-681-1-89-125.w90-88.abo.wanadoo.fr [90.88.30.125]) (Authenticated sender: maxime.ripard@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id C491B100010; Mon, 8 Apr 2019 10:41:57 +0000 (UTC) Date: Mon, 8 Apr 2019 12:41:57 +0200 From: Maxime Ripard To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= Subject: Re: [PATCH v3 1/6] arm64: dts: allwinner: h6: move MMC pinctrl to dtsi Message-ID: <20190408104157.tdxg2al3fpanhqqu@flea> References: <20190408092619.23152-1-peron.clem@gmail.com> <20190408092619.23152-2-peron.clem@gmail.com> MIME-Version: 1.0 In-Reply-To: <20190408092619.23152-2-peron.clem@gmail.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_034208_622867_A03BD2D3 X-CRM114-Status: GOOD ( 15.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Jagan Teki , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: multipart/mixed; boundary="===============3844333449207332895==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3844333449207332895== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="z3higc46mou4if3b" Content-Disposition: inline --z3higc46mou4if3b Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 08, 2019 at 11:26:14AM +0200, Cl=E9ment P=E9ron wrote: > There is only one pinmuxing available for each MMC controller. > > Move the pinctrl to the SOC > > Signed-off-by: Cl=E9ment P=E9ron > --- > arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 2 -- > arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 4 ---- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 ++++ > 3 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch= /arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi > index b2526dac2fcf..62e27948a3fa 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi > @@ -56,8 +56,6 @@ > }; > > &mmc0 { > - pinctrl-names =3D "default"; > - pinctrl-0 =3D <&mmc0_pins>; > vmmc-supply =3D <®_cldo1>; > cd-gpios =3D <&pio 5 6 GPIO_ACTIVE_LOW>; > bus-width =3D <4>; > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/= arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > index bdb8470fc8dc..4802902e128f 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > @@ -104,8 +104,6 @@ > }; > > &mmc0 { > - pinctrl-names =3D "default"; > - pinctrl-0 =3D <&mmc0_pins>; > vmmc-supply =3D <®_cldo1>; > cd-gpios =3D <&pio 5 6 GPIO_ACTIVE_LOW>; > bus-width =3D <4>; > @@ -113,8 +111,6 @@ > }; > > &mmc2 { > - pinctrl-names =3D "default"; > - pinctrl-0 =3D <&mmc2_pins>; > vmmc-supply =3D <®_cldo1>; > vqmmc-supply =3D <®_bldo2>; > non-removable; > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/bo= ot/dts/allwinner/sun50i-h6.dtsi > index 3e4bb0b0de69..006d3b6418af 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > @@ -278,6 +278,8 @@ > resets =3D <&ccu RST_BUS_MMC0>; > reset-names =3D "ahb"; > interrupts =3D ; > + pinctrl-names =3D "default"; This is indented with spaces and not tabulations. This error is reported by checkpatch. > + pinctrl-0 =3D <&mmc0_pins>; > status =3D "disabled"; > #address-cells =3D <1>; > #size-cells =3D <0>; > @@ -306,6 +308,8 @@ > resets =3D <&ccu RST_BUS_MMC2>; > reset-names =3D "ahb"; > interrupts =3D ; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&mmc0_pins>; I guess you meant mmc2? Can you test your patches before sending them please? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --z3higc46mou4if3b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKsldQAKCRDj7w1vZxhR xXGnAP99TBRvSJ0rpD/2Yfgh6WXHm7ypxBGhdz34nxuZCeghpAEAiRChgRYD5zk3 uXjFTbssB+DHZmn119gguJEO9itM1QA= =fgYB -----END PGP SIGNATURE----- --z3higc46mou4if3b-- --===============3844333449207332895== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3844333449207332895==--