From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19587C10F14 for ; Mon, 8 Apr 2019 17:44:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E405A2084F for ; Mon, 8 Apr 2019 17:44:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EuKZMagK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E405A2084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8s22P62spT8Vq6fcYxq5ZyDyaau+5KV30PMayLAAjqg=; b=EuKZMagKH5LJQe hWsVH1TKcoxgdQQkqT3Q3/Yh9oaFa+TNtQxyhAQTlVKT31bY33FWOGOepcwaV7rBnvlrwKEa6ewX0 gXjlM2/99qiJtGNGs4tEfU1NU4y2xzSXIA/Hwn7hxNhY3uAfB3uH2RCjuFojvtG9qT2L9UE+IaCWO s36zL7pxFlM9bfr9bjL76JaZTFBSo8Us07ho8y4DUbJp0/VxuFyNcMJs9qSjMCCnh0indUEjTGKyw vqPlocPsq7EgqoQnCPQoxWuNagIKimCc1DCtitQU7lgXwCkT08SBTnvrpgodCpPn2IGI1r4u+fLRh gr0rJngzSQomzkcI9Q7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDYJJ-0007Gf-D3; Mon, 08 Apr 2019 17:43:57 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDYJF-0007GK-VY for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2019 17:43:55 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 24DFB80AA; Mon, 8 Apr 2019 17:44:08 +0000 (UTC) Date: Mon, 8 Apr 2019 10:43:49 -0700 From: Tony Lindgren To: Keerthy Subject: Re: [PATCH v3 0/4] AM437x: Add rtc-only + DDR mode support Message-ID: <20190408174349.GM49658@atomide.com> References: <20190403045742.2243-1-j-keerthy@ti.com> <20190408172654.GL49658@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190408172654.GL49658@atomide.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_104354_049268_C39CC427 X-CRM114-Status: GOOD ( 12.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@bootlin.com, d-gerlach@ti.com, t-kristo@ti.com, ssantosh@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Tony Lindgren [190408 10:26]: > * Keerthy [190402 21:57]: > > Changes in v3: > > > > * Exported out omap_rtc_poweroff_program function & removed > > the patch to add a generic rtc interface as it is specific > > to am43 at the moment. > > Thanks I'll be applying this series into omap-for-v5.2/am4-pm > today. Sorry correction for the branch named above. I noticed a build warning and folded in the following fix. We need to return -EINVAL if tm2bcd() fails like we do elsewhere in the driver. So I just pushed out a new branch omap-for-v5.2/am4-pm-v2. Please just ignore the earlier branch omap-for-v5.2/am4-pm. Regards, Tony 8< -------------------- diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc-omap.c @@ -447,7 +447,7 @@ int omap_rtc_power_off_program(struct device *dev) if (tm2bcd(&tm) < 0) { dev_err(&rtc->rtc->dev, "power off failed\n"); rtc->type->lock(rtc); - return; + return -EINVAL; } rtc_wait_not_busy(rtc); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel