From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49F41C10F13 for ; Mon, 8 Apr 2019 18:08:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CE672084C for ; Mon, 8 Apr 2019 18:08:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="koRQa70f"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JfLNlMat" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CE672084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eG2Tkph01h2gd8D5oEZs0T3PEXBJx137CAO5tf14Y/Y=; b=koRQa70f4iVsGQ 46ZP5nKp4kaGiR0xXjA4pVol6QyKJpJ5us/Dg3A3J0YRoim9Gq4WrYJuj5dbr5RgwVzhs0ueHagOz GqFEOgPObfTiiMjy5NP6atQYm9dBm8v+cEvXDSpB7hnp0Dw24M6DoDauxJKoFz3zP7/9WomogVbqz 6Q/1WRDhq5DFYkoMF1sfqnvfrxSAVkOMZvmJaqG3PrgbXUpFLzZBbnh2PBzidtRmJiOXT/Xa6BFqn 1wu/qKcQqUBeenUYnCDC81VFVpSNWryfu4h5A7KXUE+8dvXQQhVwHwa5RFVXVrY85bvgfN/e5bNgf +442k0RoPoaMajm8DOTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDYgY-0007h1-26; Mon, 08 Apr 2019 18:07:58 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDYgU-0007gh-OL for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2019 18:07:56 +0000 Received: by mail-pg1-x542.google.com with SMTP id i2so7745542pgj.11 for ; Mon, 08 Apr 2019 11:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4Vw+jqU8/Q/NfNhkCQ7NB5tYS522weWWpd/A6CbS8wQ=; b=JfLNlMat8BGG2rMe452PjOLTYHDr5xES8aYwHpc8Iux6s0tt/WELkxHZHMhgP+k6w1 UE9wQf5RgYwHEpxfi6p0Z72JDkuiLdOGyCXF1fabGwQIxFv6ODmplaA2ne5grFVdFcMx qHfK0fkd/MbsWb8HVEF4bUKMImEkvBo3TEGw9TTu9JGQpxX8JqDODi4UHGYY6q/pORwW I3hm1ROfRJE4AqGTRPnVeJ1PDsesE9f4Zq7OoMhvCjrrgs3a8t55DmkZ4RcgjxY8TYu8 gotkUDtTfMb5JCJJddTVf5/RzB+aTnTIb0egl9bLlcnOGeiwfsg3g8e6cC3Y/+H9Vwr8 UVYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=4Vw+jqU8/Q/NfNhkCQ7NB5tYS522weWWpd/A6CbS8wQ=; b=EVQlrJN4ElmtMQvN1W7GxAO2M3o82MJmoCMoTSh73bOv43YrgKcmkMXW/89vS9kk3C qXzLMiDzt8zJvZryZoVLuJMVUgDLYT0lxMMC+cJDgZs1vn9DPjqaZzehGsZj+k7+t+xY 7/PfNGWhm1iWMPL4tU0T5AXCKIKHoYqBBaLMyCfqXRitfwYWwqGLrdc/Xt9y613/8SiB sq8Inoy6icc02xwfPetiKelJEui5O0yD3Qb6zISRbsrZuxSmBIYfyIat2D/mAEsLXUzG 8VVk40f3vXFKhX9k0GOu1Y+0NfUBHlSeVYuTOUiS4n7H5BKqeOvr0d2RZmVkDQpZECMW 1JtQ== X-Gm-Message-State: APjAAAUruzHg56AmJrq/4oxEhjmNhH1nDwf5wHgsgOHjDMmKVvmkSzcF PGl4mZnqbict3pCX9FWGQes= X-Google-Smtp-Source: APXvYqwq6TQ6numuLHobw3qOIegvKbJeqsj73KvkJNUsvDwBiOaRe7HuUfPXSD7/mcCwGYnvCwJerg== X-Received: by 2002:a62:292:: with SMTP id 140mr31695541pfc.206.1554746873883; Mon, 08 Apr 2019 11:07:53 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id h187sm53917141pfc.52.2019.04.08.11.07.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Apr 2019 11:07:53 -0700 (PDT) Date: Mon, 8 Apr 2019 11:07:51 -0700 From: Guenter Roeck To: Marc Zyngier Subject: Re: [PATCH 2/7] watchdog/sbsa: Use arch_timer_read_counter instead of arch_counter_get_cntvct Message-ID: <20190408180751.GA28778@roeck-us.net> References: <20190408154907.223536-1-marc.zyngier@arm.com> <20190408154907.223536-3-marc.zyngier@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190408154907.223536-3-marc.zyngier@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_110754_825918_0199F250 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Russell King , Catalin Marinas , Daniel Lezcano , Will Deacon , linux-kernel@vger.kernel.org, Wim Van Sebroeck , Valentin Schneider , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 08, 2019 at 04:49:02PM +0100, Marc Zyngier wrote: > Only arch_timer_read_counter will guarantee that workarounds are > applied. So let's use this one instead of arch_counter_get_cntvct. > > Signed-off-by: Marc Zyngier Reviewed-by: Guenter Roeck ... assuming/hoping that those counters are actually the same. Guenter > --- > drivers/watchdog/sbsa_gwdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c > index e8bd9887c566..e221e47396ab 100644 > --- a/drivers/watchdog/sbsa_gwdt.c > +++ b/drivers/watchdog/sbsa_gwdt.c > @@ -161,7 +161,7 @@ static unsigned int sbsa_gwdt_get_timeleft(struct watchdog_device *wdd) > timeleft += readl(gwdt->control_base + SBSA_GWDT_WOR); > > timeleft += lo_hi_readq(gwdt->control_base + SBSA_GWDT_WCV) - > - arch_counter_get_cntvct(); > + arch_timer_read_counter(); > > do_div(timeleft, gwdt->clk); > > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel