From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD2E2C10F13 for ; Mon, 8 Apr 2019 18:28:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4B7C20830 for ; Mon, 8 Apr 2019 18:28:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V6EgxoWp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="OZUOmf98" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4B7C20830 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DDwKSfx/bR066s1Ywu9O4AJV3V5fcHlD2GUI4SySG7o=; b=V6EgxoWptXqpbA EOie5FTo2L8ye1FGp2h1YkKEe9r9qcPEZz+uxeLn+NQJbvMKaieMp7bbSWSSWx9plEruZQGGrLnrQ A643AAByAkTAgcbxonj67PEWisQg3sZjN/toeKYWb8W1KrCld9nklmsYLBE96iHcOddH64VXXfHdu piFebuzmupB6+iQZhuvh01nMiWZ8XY+mZ9IqDsCpt81EtGnZN7xbhNG/AeN03SCNfJiOtTz7emE6M bQpBhecEJxJleBVpB11OZacks9lGmazO4vzqmLB7zdg8nCmtBj9bffoKsMZUoz8tnTHZhgVCwoZm0 v/AG4d63SW9yrCeYjDVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDYzz-0000FT-Ag; Mon, 08 Apr 2019 18:28:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDYzx-0000Eo-2g; Mon, 08 Apr 2019 18:28:02 +0000 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5311320830; Mon, 8 Apr 2019 18:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554748080; bh=1uwiHjEa6EotDTSkRze2ILL+rxMsqsFwdUCIYELJ91I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OZUOmf98oufAbWaj0vjtI1XE8vrdicnZ2su8UoRaPdjhrL6V8iEw9/Bnfd8sLfsr2 mBaAtbR6TnoONdRK/pq0n/hRpoZOqo+DbRMKgJNoEmfVpZpPuMFpa0Vbb/Mra5GNTC 2sSHJo6xxQfTHfTyOrlaNuXDb/duyzrx0AmaHkYk= Date: Mon, 8 Apr 2019 11:27:58 -0700 From: Eric Biggers To: Pascal Van Leeuwen Subject: Re: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext Message-ID: <20190408182757.GD9145@gmail.com> References: <20190126210530.GB709@sol.localdomain> <1894799.pWIprST79S@phil> <20190315033140.GB1671@sol.localdomain> <20190404171204.GA121392@gmail.com> <20190407124211.fv7pjsozxhnhw56i@gondor.apana.org.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_112801_141907_60AA16CC X-CRM114-Status: GOOD ( 10.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tao Huang , Zain Wang , Herbert Xu , Arnd Bergmann , Ard Biesheuvel , Zhang Zhijie , "linux-rockchip@lists.infradead.org" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Olof Johansson , "ezequiel@collabora.com" , linux-arm-kernel , Heiko Stuebner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Apr 07, 2019 at 07:12:43PM +0000, Pascal Van Leeuwen wrote: > > Fact is, there are at least 2 hardware device drivers NOT doing this - and > I want to bet a nice sum of money there will be more - and that this has > not been noticed prior to adding these tests to testmgr, otherwise this > would have been fixed by now. Which seems to confirm that there is no > real use case for this functionality. > I really shouldn't have to say this, but just because something hasn't been reported doesn't mean it's not a real problem. Someone could easily be affected by one of these bugs where crypto drivers produce the wrong output, and never notice it because their use case doesn't involve checking the output against another implementation. Or, perhaps they noticed but never reported it upstream. Or perhaps they didn't have the time or skill to debug the problem so just they disabled the broken driver, or used No Crypto instead. That's why we have tests -- so bugs can be detected immediately rather than maybe years out in the field after causing critical security vulnerabilities. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel