From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E6CAC10F0E for ; Tue, 9 Apr 2019 07:22:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F028F20833 for ; Tue, 9 Apr 2019 07:21:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h4q3SFML"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="VrYidqeX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F028F20833 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Cc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KmdyQyhE/uc7JXZ48M0OGG5WXNoWWk469BB8rgC3an8=; b=h4q3SFMLpIDS2j9hysxK0JXZl yvoY7N+LM8EDAkqrcPLLe8q7CCoQC8LkiPavlmRzvJaSU0T+KTTRxKled0LH3xVG0dwiZxsFRikS9 Wx8zeJTBWCcn8Jfd4pq4HNG9okKajTlJKxXdjFRipAU3UEFvajo+vfDkOg2snGyxgGwgKBblSI+lL YycM+NJ45bfFi7f8diBGE200x3mhiUtiPKrC0IBjXyi0ygxC8BYTAsVlEZlg5ofeVkZCqnc0ErPSD SHhpuFz7tsK+CP8UPsxAGMu6MebGUm6pvmTDRIuvtkItJ3Ct7tVBa41vDfyXDOXFeE9K1gIsV3cJ1 M9r3hkDBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDl4v-0001he-PX; Tue, 09 Apr 2019 07:21:57 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDl4R-00011Y-Cc for linux-arm-kernel@bombadil.infradead.org; Tue, 09 Apr 2019 07:21:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=22xdco0mKK7fq0olPLIsNRj+i2JrYHLeql08nbST2W4=; b=VrYidqeX1LA1CjtXGYLQYyiwp 4H/McMEUBSsDhhiJZQGBhxZISQjzgWONc4wqMSIVFU6kUmjBYZpbjSKa9zZ6NZ9bD+XPBe58JK+W9 e7VuubqTDqbR1NGI20u1Vjxl3YgWdqDC/BC//TYt+3EQE9aYcd2OvKI59/SKZqBuOV9oPfcZrb4OZ oW99GE6eY++z7IACC8xAXMMvoRWfvAq/JoN7EO7vD1r3kSWVNE9g+9R33nXrkrLoVdUUiv8OTN1rz fv7lPrIK1qP2JYIRyUkduGNcwDQnEyRrPGZEAxhp8GWf5KI0de7dLO8jorjZ6J1fcrDTRvTGLv03g K/3SQLkIg==; Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDl4N-0005Hg-PD for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2019 07:21:25 +0000 X-Originating-IP: 90.88.30.125 Received: from localhost (aaubervilliers-681-1-89-125.w90-88.abo.wanadoo.fr [90.88.30.125]) (Authenticated sender: maxime.ripard@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 1777F20019; Tue, 9 Apr 2019 07:20:45 +0000 (UTC) Date: Tue, 9 Apr 2019 09:20:45 +0200 From: Maxime Ripard To: linux-sunxi@googlegroups.com, Chen-Yu Tsai , Rob Herring , Linus Walleij , David Airlie , Daniel Vetter , Mark Rutland , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , Naveen Gupta , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, linux-gpio@vger.kernel.org Subject: Re: [PATCH 08/12] arm64: dts: allwinner: h6: Add MMC1 pins Message-ID: <20190409072045.hb6us26bgfk36am5@flea> References: <20190405234514.6183-1-megous@megous.com> <20190405234514.6183-9-megous@megous.com> <20190408074327.vvubj2sbkvfkwscv@flea> <20190408224104.qwhk33qgem7bq5y7@core.my.home> MIME-Version: 1.0 In-Reply-To: <20190408224104.qwhk33qgem7bq5y7@core.my.home> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_032124_043772_9DA03214 X-CRM114-Status: GOOD ( 24.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8712810291939387421==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8712810291939387421== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7jz5mnkpwhgqarbm" Content-Disposition: inline --7jz5mnkpwhgqarbm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Apr 09, 2019 at 12:41:05AM +0200, Ond=C5=99ej Jirman wrote: > On Mon, Apr 08, 2019 at 09:43:27AM +0200, Maxime Ripard wrote: > > On Sat, Apr 06, 2019 at 01:45:10AM +0200, megous@megous.com wrote: > > > From: Ondrej Jirman > > > > > > --- > > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm6= 4/boot/dts/allwinner/sun50i-h6.dtsi > > > index 91fecab58836..dccad79da90c 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > @@ -238,6 +238,15 @@ > > > bias-pull-up; > > > }; > > > > > > + > > > > Extra line > > > > > + mmc1_pins: mmc1-pins { > > > + pins =3D "PG0", "PG1", "PG2", "PG3", > > > + "PG4", "PG5"; > > > + function =3D "mmc1"; > > > + drive-strength =3D <30>; > > > + bias-pull-up; > > > + }; > > > + > > > > Is that the only muxing option? > > I don't think so. I believe someone can use a 1-bit interface (bus-width = =3D <1>), > and then some data pins will be free. This pinconfig is for 4-bit bus wid= th > setup. > > Though other SoCs (ex. H3, A83T) don't consider this possibility and make= the > 4-bit config the default pinctrl for mmc1. To add to the confusion, on th= ese > SoCs 4-bit pinconf is the default, but 1bit bus-width is the (implicit) d= efault. > This led to some confusion in the past. > > So we can either: > - keep consistency with what is done elsewhere, and make this default, de= spite > not being the only option, What is done elsewhere is that if it's the only option, just call it $controller_pins and make that the default. If it isn't, then call it $(controller)_$(bank)_pins, and put it at the board level. If it's not the only muxing option, then your name should be called mmc1-pg-pins > - or perhaps I can rename this to mmc1_bus_width4_pins, or somesuch, to m= ake it > more explicit, and keep it non-default. We haven't encountered a case where the 1-bit bus was actually used, so there's no need to take care of that. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --7jz5mnkpwhgqarbm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKxHzQAKCRDj7w1vZxhR xV69AQDu5vz95FMuzwKpnH/2dqyIpqkLhnlJ2qZWB3w89izbGwEA//TvxSJVoN9r epGq3k20xJPD5I5EhlTm/71n7aM4Bw4= =m5Av -----END PGP SIGNATURE----- --7jz5mnkpwhgqarbm-- --===============8712810291939387421== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8712810291939387421==--