From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC46C10F0E for ; Tue, 9 Apr 2019 10:52:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A1682084C for ; Tue, 9 Apr 2019 10:52:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nTFQee11" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A1682084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=diaspDgM3IqwXBKuSI8lo+UWJJgcfY8bLcB60Z91X20=; b=nTFQee11MWw5W9 D6/Lhki9GnDBNas8zwWI84uywsYvrATh/qKdkBFCW4bEnCtayMEUsj8hDRh3FwwQZE/PdVEiTZCeY RPtQEVH3/abZH2GyvrYIuYMl3/LmFf/Q1tce5IE8RzjEhuVNOx3dFsdH2IFn39rLv1vVfUsRjZFgL AJjkuNGAVXgQRdK3v7VFOUv+BK+UuH1CmqBKR82OOKkmbbH72iCl32S3ol9k4cXiWbTocxUAt88eD kwZiJ+PPpdIyTiAdbczROBUda1iK3X5VBl20u9eDMyyu3LSnydUVwmlgQwrtnn5NXDYBo3iuhcEas 7UBBEcm6r3QsiSZvq6xQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDoMl-0006fu-5t; Tue, 09 Apr 2019 10:52:35 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDoMi-0006fX-R1 for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2019 10:52:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2E96DA78; Tue, 9 Apr 2019 03:52:32 -0700 (PDT) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8D8063F59C; Tue, 9 Apr 2019 03:52:31 -0700 (PDT) Date: Tue, 9 Apr 2019 11:52:29 +0100 From: Andrew Murray To: Suzuki K Poulose Subject: Re: [PATCH v12 2/8] arm64: KVM: encapsulate kvm_cpu_context in kvm_host_data Message-ID: <20190409105228.GA25919@e119886-lin.cambridge.arm.com> References: <20190328103731.27264-1-andrew.murray@arm.com> <20190328103731.27264-3-andrew.murray@arm.com> <387fe2b5-683d-f5a4-9aec-f621292429ba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <387fe2b5-683d-f5a4-9aec-f621292429ba@arm.com> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_035232_882115_EB6842C4 X-CRM114-Status: GOOD ( 18.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, julien.thierry@arm.com, marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, christoffer.dall@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 28, 2019 at 03:28:37PM +0000, Suzuki K Poulose wrote: > On 03/28/2019 10:37 AM, Andrew Murray wrote: > > The virt/arm core allocates a kvm_cpu_context_t percpu, at present this is > > a typedef to kvm_cpu_context and is used to store host cpu context. The > > kvm_cpu_context structure is also used elsewhere to hold vcpu context. > > In order to use the percpu to hold additional future host information we > > encapsulate kvm_cpu_context in a new structure and rename the typedef and > > percpu to match. > > > > Signed-off-by: Andrew Murray > > --- > > arch/arm/include/asm/kvm_host.h | 8 ++++++-- > > arch/arm64/include/asm/kvm_asm.h | 3 ++- > > arch/arm64/include/asm/kvm_host.h | 16 ++++++++++------ > > arch/arm64/kernel/asm-offsets.c | 1 + > > virt/kvm/arm/arm.c | 14 ++++++++------ > > 5 files changed, 27 insertions(+), 15 deletions(-) > > > > diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h > > index 770d73257ad9..427c28be6452 100644 > > --- a/arch/arm/include/asm/kvm_host.h > > +++ b/arch/arm/include/asm/kvm_host.h > > @@ -150,7 +150,11 @@ struct kvm_cpu_context { > > u32 cp15[NR_CP15_REGS]; > > }; > > -typedef struct kvm_cpu_context kvm_cpu_context_t; > > +struct kvm_host_data { > > + struct kvm_cpu_context host_ctxt; > > +}; > > + > > +typedef struct kvm_host_data kvm_host_data_t; > > static inline void kvm_init_host_cpu_context(kvm_cpu_context_t *cpu_ctxt, > > int cpu) > > We need to fix this function prototype to accept struct kvm_cpu_context, > instead of the now removed kvm_cpu_context_t, to prevent a build break > on arm32 ? Yes this was a breakage, thanks for pointing this out. Thanks, Andrew Murray > > With that : > > Reviewed-by: Suzuki K Poulose _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel