From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C184FC10F0E for ; Tue, 9 Apr 2019 16:12:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A8822133D for ; Tue, 9 Apr 2019 16:12:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OYc3PiPr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Rqob12LH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A8822133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0qqk2mtLZa/DDdNIBRPl1N7+YovqVNFJN7YwygtSEB4=; b=OYc3PiPr2xP1L3 L2hzJMGoDjWqTKtcBTTE0klO4Ou8rCTpOk5vu+AT3m+FTKZL4AXgjMNUpYf7hY/Gziy2n7YdcXyPk nzp15xGScd+DHxLi6GE1rKNjh1TTGaoyfjzG3JVpS206fm/QPYjAeBCPwnCkI2oXY9wgdCvEuHZ9Y ugCrPGQH6lpFUj8GJrRrtIsCC+XxyvWcHydGo8nxEcMsPbgTfCpFaUn7s6aA1zrsKIiu6b8+F4nkS vyxBVMyafpOpAU+/tX0iNMyQWixB/9IugbIC2tJGzOyBwiQMM/J/zkUkHXzq8NDmAGbnnlquO+kWc /v1sGoNoDsKlApvXjPCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDtM5-0004jg-TN; Tue, 09 Apr 2019 16:12:13 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDtM3-0004jY-HK for linux-arm-kernel@bombadil.infradead.org; Tue, 09 Apr 2019 16:12:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=S4ArIDjaRDVjCCD9jFlCWpRZQeGdzkqhD5RJ38zmT0E=; b=Rqob12LH5hzWj8W2SGMi5q29e svi4BDLLyD1KhsIuTCL0A4XEv1pOg9Xbl8FjySeacDai0aSgV3i10xMlE6hXM3uwA07gZZkq+/Stg jPn364PabvUwaExrJV7TcjEq1LSsaPf+2y77pErxZ5eDu30eK89+mmLa12V9Oq+Zk/F+FhFadNtV+ VSHHJeKfVILSpMw2vZ0Ep4zZQ5Um/8+9QVCGl4F+yhga9Hma023W5glynqMhKFqSOnthkCyVuKmA1 XJavWI3MS0QarwmtjgT4Ik0moTrvkpqkHadHC5v15IxUWjV0I0GGgLbWtnCjKEcm8Zc5XSQWcICyU xVgxGejKA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDtM0-0001AC-Id; Tue, 09 Apr 2019 16:12:08 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id E5477201F29A3; Tue, 9 Apr 2019 18:12:04 +0200 (CEST) Date: Tue, 9 Apr 2019 18:12:04 +0200 From: Peter Zijlstra To: Raphael Gault Subject: Re: [RFC 3/6] objtool: arm64: Adapt the stack frame checks and the section analysis for the arm architecture Message-ID: <20190409161204.GS11158@hirez.programming.kicks-ass.net> References: <20190409135243.12424-1-raphael.gault@arm.com> <20190409135243.12424-4-raphael.gault@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190409135243.12424-4-raphael.gault@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: julien.thierry@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org I'm just doing my initial read-through,.. however On Tue, Apr 09, 2019 at 02:52:40PM +0100, Raphael Gault wrote: > + if (!(sec->sh.sh_flags & SHF_EXECINSTR) > + && (strcmp(sec->name, ".altinstr_replacement") || !IGNORE_SHF_EXEC_FLAG)) > continue; could you please not format code like that. Operators go at the end of the line, and continuation should match the indentation of the opening paren. So the above would look like: > + if (!(sec->sh.sh_flags & SHF_EXECINSTR) && > + (strcmp(sec->name, ".altinstr_replacement") || !IGNORE_SHF_EXEC_FLAG)) > continue; You appear to be doing that quit consistently, and it is against style. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel