From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0570C282CE for ; Tue, 9 Apr 2019 16:20:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9073B20833 for ; Tue, 9 Apr 2019 16:20:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PUQXfeqh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="OpDzbeTN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9073B20833 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nxMglzvrskSYRKl/86OfK0FHzrha4AP1Ki/XZRXz4xc=; b=PUQXfeqhHKsvXJ kLCE8falXeuOhLIuUZRr8J0xUQ2xay6Qdf0B0Fti9s/oYmaMPm2glTbx3uMlH7i6t65viUNmMjOcv Z24FafL74ymvDSQ8hHcs7ol0Kn8fxUccYN5Ffjolt0DU/PYAJcE6UnHJ03iUZJakbnbqAiYrwEoJ3 NJ9s7ouYm2x4jPHq5PZIEknDBc2jC5vCHw3FO0rzarcTo0TDWa2q9yjZW0qLgcXPHGqp/BT4FM12X 6qohuuZxOl/VRHL6osz6m8tApMztppcCDwXm3kBZFjpDJQzsRyCS30cnWgEB3n4yD3m75R8k9s9dk ndbNDEQ72BkZ9+Sy2ANQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDtUD-0000q1-NQ; Tue, 09 Apr 2019 16:20:37 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDtU8-0000pk-KX for linux-arm-kernel@bombadil.infradead.org; Tue, 09 Apr 2019 16:20:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9imv8zmeNakxRzEk5Gp6PO+5BWFNMWRb4XZCaz5T864=; b=OpDzbeTN0eTNcSzbJSfUzlzlH tffFRcXesd1LRtPlJWom6JqRr/wMvNWW27ajHc7TH3/5f8h+jx/QuyQA77PDDlKr+2KL+8hiJ2rg5 yZmTPkU049xb6YBx3DwodswZbKFh1eknhPUFwWLfqQHIY3EY0DX0tsLUpixilERgcNTRd0m/CtuGn 6EK8uTXe8nYW8xqcg8yYxDxg67JvRg2bPup/omtvMSI5JmhqpTqgEU9ImbohXUqtDAt2qln4K2HNA 9pVmRch2REayQlUp5S0PYccHDet9XY7Az9OaUlO7ErOclGzPm5XzbYyf5FgWhCzB+GDZ/AKuiXXxq vM0xza87w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDtU6-0001Cb-DG; Tue, 09 Apr 2019 16:20:30 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id F27A0201F29A3; Tue, 9 Apr 2019 18:20:28 +0200 (CEST) Date: Tue, 9 Apr 2019 18:20:28 +0200 From: Peter Zijlstra To: Raphael Gault Subject: Re: [RFC 2/6] objtool: arm64: Add required implementation for supporting the aarch64 architecture in objtool. Message-ID: <20190409162028.GT11158@hirez.programming.kicks-ass.net> References: <20190409135243.12424-1-raphael.gault@arm.com> <20190409135243.12424-3-raphael.gault@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190409135243.12424-3-raphael.gault@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: julien.thierry@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 09, 2019 at 02:52:39PM +0100, Raphael Gault wrote: > The decoding of the instruction is split into classes and subclasses as described into > the Instruction Encoding in the ArmV8.5 Architecture Reference Manual. > tools/objtool/arch/arm64/decode.c | 2843 +++++++++++++++++ Oh man, I hope you generated much of that from the ARM64 Instruction Set Architecture XML files [*]. Otherwise that's been a lot of typing. Anyway, since you now have that, would it make sense to use this same decoder in your kernel tree? I found at least one partial decoder in arch/arm64/kernel/probes/decode-insn.c, but I suspect you have more. (Note kprobes is how x86 initially grew its instruction decoder IIRC) * https://developer.arm.com/architectures/cpu-architecture/a-profile/exploration-tools _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel