From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F216C10F0E for ; Tue, 9 Apr 2019 16:24:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5035D20883 for ; Tue, 9 Apr 2019 16:24:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ftEKbQrx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5035D20883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LxO4/BDbq4XXLP4iOk/vmr5z2iHy1/CrokEcX8J878I=; b=ftEKbQrxCuJAd4 ELS6DULh0NJJ8qm4cVi0QYohILXOULUat2V5BqrzmtR1x3jDGRAV/2v4ddfXhUAeKGkbs8jWBw4nB /PI0YDEoKJhYMyT2ZTlxjd7szgG+f4IRH9RI82RjSBaxFOTZ4OWrM7r3q2fitn47k8s+LZa4GNy3m a+wGIn6W4Y3Ot9S2hpnsetuwa4MJbLhE9CcUAiZLWQ51SMcEwlo2t0FrKiDPXxEQrJAR4VRXLR9/g WR0fhzjyOH0GhzMeXBm2nJDIIIan4VA8rFeOnORbHETu+ouH+SIDNdu+ImVeds8E2UJrcs+df8CX8 aJPX2mnLurQVDLxLcO2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDtXw-0001cz-Jf; Tue, 09 Apr 2019 16:24:28 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDtXt-0001cD-OX for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2019 16:24:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E60C15AB; Tue, 9 Apr 2019 09:24:25 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 87FF63F68F; Tue, 9 Apr 2019 09:24:23 -0700 (PDT) Date: Tue, 9 Apr 2019 17:24:21 +0100 From: Mark Rutland To: Peter Zijlstra Subject: Re: [RFC 3/6] objtool: arm64: Adapt the stack frame checks and the section analysis for the arm architecture Message-ID: <20190409162420.GB32587@lakrids.cambridge.arm.com> References: <20190409135243.12424-1-raphael.gault@arm.com> <20190409135243.12424-4-raphael.gault@arm.com> <20190409161204.GS11158@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190409161204.GS11158@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_092425_798569_843617D0 X-CRM114-Status: GOOD ( 13.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: julien.thierry@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, Raphael Gault , jpoimboe@redhat.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 09, 2019 at 06:12:04PM +0200, Peter Zijlstra wrote: > > I'm just doing my initial read-through,.. however > > On Tue, Apr 09, 2019 at 02:52:40PM +0100, Raphael Gault wrote: > > + if (!(sec->sh.sh_flags & SHF_EXECINSTR) > > + && (strcmp(sec->name, ".altinstr_replacement") || !IGNORE_SHF_EXEC_FLAG)) > > continue; > > could you please not format code like that. Operators go at the end of > the line, and continuation should match the indentation of the opening > paren. So the above would look like: > > > + if (!(sec->sh.sh_flags & SHF_EXECINSTR) && > > + (strcmp(sec->name, ".altinstr_replacement") || !IGNORE_SHF_EXEC_FLAG)) > > continue; > > You appear to be doing that quit consistently, and it is against style. Raphael, as a heads-up, ./scripts/checkpatch.pl can catch issues like this. You can run it over a list of patches, so for a patch series you can run: $ ./scripts/checkpatch.pl *.patch ... and hopefully most of the output will be reasonable. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel