From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02629C10F11 for ; Wed, 10 Apr 2019 05:45:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8D342084B for ; Wed, 10 Apr 2019 05:45:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qizvvBLI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nRfrAlRU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8D342084B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D+h5nLAn6+niZyTbxXsL12IkaT/zCJIA93GSTmqXPBw=; b=qizvvBLIbnwKmR Qz3n08qkfPV109pu/fRyiWzR5UAg/+VA2vPl1/rFFiVVK3dVkV7794647g65R+OC+uUo8ErnWAEr6 rTmw9/mUW+vazS7pdlF0swwnabMv7HguUSZGgStHCbf+LJwErN0D2lTRCdZUgXibLO90ARnCQ3nn+ QwHhmxstjVwkAp76xnpolVdxSa1IyLKFv6t9VGk9GJvRyOWd/QlWrx4VuYUFfsGkno43pQtOQozjv 5yD9S96FBa9NlrdMf8s7V1x8ns6fAPdHb9CT2wxozIFYnKTXGxnjeNJ/C2I85YLPTrz2eXlPbJaMa otPbiWfkqBbhfWKFRE7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hE62a-00057t-SN; Wed, 10 Apr 2019 05:44:56 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hE62Y-00056y-2w for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2019 05:44:55 +0000 Received: by mail-pg1-x541.google.com with SMTP id f6so830134pgs.8 for ; Tue, 09 Apr 2019 22:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7MxHhKmonGaKJ09XyLO+r+flNmHvbw8fazpe3XvA4IU=; b=nRfrAlRUKoWeXfiOHLT/5gmYar2X7MosuoRm4Z6nSLvrGtoHJlWBOAkwvpX3t6U9wV KA5p0bPA0qnm5xgAcA7y6zwTIw+oqMnN2bcPqZ3k+HSwwv4BaGRWMXu9IRUwlh4JtYxQ IY5azFjlMyjm5nvgEuMGvnsgGG6dl4Mk6wcuBTonapx/0kJsmszX+ZVi0GAt4A0fFFmh zLycnR2rJ9MB6LYpmoGK3H6x+e5jpQH8F3o5EU4BZRRtwDicnCavqRzE6s4RzijU9Km1 pH/9xPh7LD566aIxos/zP4XO3urfk7oWoabhpHBVsS257FSsbi+MnibafP4XgylHAYjQ YR8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7MxHhKmonGaKJ09XyLO+r+flNmHvbw8fazpe3XvA4IU=; b=RystxKfPtFpLBKu+fqcyx3QCuLpJ3P7A9BST3j0ysZkrDBQknFP34PodLSLg7EpQK4 K2aw4Tg3u4G+F9XB3n0v5oe+eCWk5NYOx4HGnoiT2srrWkWc1myuWzIo3nOpdM8EXnGF v2iyJYqejw9ggwpBXYajxzNOjYvK7AvwQSaQa9YQfX6f4lkiJxc7ui9Ba46DDNmTMGAc cs98McPwzkiOxDlc4Qd2YBK4KTzBHIYDmFPSsBlTmiEzk5+1jFqu4gPuCX+aM6+yUxiO dExDDzNq6thuVBf+/MAQUnP2woUS5djjtjP4+1NJ2IEzmmIkeqR0E2fbzZDB1zeYnmoJ zNCQ== X-Gm-Message-State: APjAAAV+3f03TU1rwdG/Ow53qlK/vS+jWGuZzYKbz88Soaq+p3rPOB+o cv/mANVYEslyRL6V9FPJ48s4pw== X-Google-Smtp-Source: APXvYqyndp/71VG+LGRqwEyk+HJJYgfBrO992H+vy0dmC/lW/kaTlFij2ClbXHYtVs9wCDf+XLXt0w== X-Received: by 2002:a63:fd06:: with SMTP id d6mr39118168pgh.183.1554875092719; Tue, 09 Apr 2019 22:44:52 -0700 (PDT) Received: from localhost ([122.166.139.136]) by smtp.gmail.com with ESMTPSA id m2sm54221315pgr.74.2019.04.09.22.44.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2019 22:44:51 -0700 (PDT) Date: Wed, 10 Apr 2019 11:14:49 +0530 From: Viresh Kumar To: Quentin Perret Subject: Re: [PATCH 3/3] thermal: cpu_cooling: Migrate to using the EM framework Message-ID: <20190410054449.zwmemg7vza557gue@vireshk-i7> References: <20190328101352.25657-1-quentin.perret@arm.com> <20190328101352.25657-4-quentin.perret@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190328101352.25657-4-quentin.perret@arm.com> User-Agent: NeoMutt/20180323-120-3dd1ac X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_224454_139861_9D6E8EB6 X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, rjw@rjwysocki.net, amit.kachhap@gmail.com, daniel.lezcano@linaro.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, edubezval@gmail.com, catalin.marinas@arm.com, rui.zhang@intel.com, javi.merino@kernel.org, ionela.voinescu@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28-03-19, 10:13, Quentin Perret wrote: > +static unsigned int get_state_freq(struct cpufreq_cooling_device *cpufreq_cdev, > + unsigned long state) > +{ > + struct cpufreq_policy *policy; > + unsigned long idx; > + > + /* Use the Energy Model table if available */ > + if (cpufreq_cdev->em) { > + idx = cpufreq_cdev->max_level - state; > + return cpufreq_cdev->em->table[idx].frequency; > + } > + > + /* Otherwise, fallback on the CPUFreq table */ > + policy = cpufreq_cdev->policy; > + if (policy->freq_table_sorted == CPUFREQ_TABLE_SORTED_ASCENDING) It is not guaranteed that the frequency table is sorted in any order, isn't it ? > + idx = cpufreq_cdev->max_level - state; > + else > + idx = state; -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel