From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3CD6C10F11 for ; Wed, 10 Apr 2019 06:37:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B23722084B for ; Wed, 10 Apr 2019 06:37:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L/P8/WGX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fN+MTAes" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B23722084B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=67mFhskkp5YJuJ/gRsX2kv/rQOW9P7T7on6wmUyXD+4=; b=L/P8/WGX459Y+G AgDRRQf5jqELfnTY233wHDfyoA4bnfbNzjJzMFeRtkPJVBeKH8fyW8jj2ULasArmlv55s9ee2x999 Se1Hi7PMqDxyEgfbF63jrNMpnszIYBoq5Jy3ZLKj6LY6+ZOSNoPIG0qHlt7HA8vIahOLl7fCm/YgS bdIouwLkaSXTW7UzGDEccFPVwwnT8vCyobrK3nf1vHl7j0xADPn9tjZk3fyimEBzCmeWmnYf4c+6u veH+0Losm6h9LM0rUxnkCzyiBm1AIYMNdBtnyn8jpTvaUv/VaON7AVVBiD1ioF62pcLZem1ax3zCW +X2UACh+zYjSAa7XK99Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hE6rM-0001ey-0N; Wed, 10 Apr 2019 06:37:24 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hE6rI-0001eV-V0 for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2019 06:37:22 +0000 Received: by mail-pl1-x641.google.com with SMTP id b3so772729plr.7 for ; Tue, 09 Apr 2019 23:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Z15Euzi/7W0xWj7RGm8EBO4XV8u51E2URV+Tg7QcB44=; b=fN+MTAesy2a1t5HT9VEilFzdZlCXei702B7CZP5CB6t93Rh4kelOvfhXaH153fOE3s x9g6qn9pzt2KwJ/l7k4clHhr9GRq2XyzB7LP2wRSDnGMiuI+aM2b3tH5evkrr6DvkRUj MedJjeOydOUof6pnSfEzK+0VmRxl9zmT6q+q1pQjqfSELg+/QcilVWNlceGYMqdZf3il Pi7X0HIK6K7K2by7bDscJN0KKzrEI0MNRNq1oNwyaPxiWXVLgRTQW1g6Iz1K+bgxIWT2 zHSspKyJJHEOciQbocPf2cIUv1JaqJNMGaGB07d/qzOZ/TUSZVZ8SNidCfY8oblJoo+p GVcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Z15Euzi/7W0xWj7RGm8EBO4XV8u51E2URV+Tg7QcB44=; b=fEBaeYerl3UZDXYdxBWHg+2+EDQbE2Z9FPt3Exovu1yQvk7zh3eUdtHo7JuXq7axtj pm2fU7GTBIKjo3t1M+YkV8xdXvDyDsRG6HKDmalKdf+rZ2ouf6phD7XPxsh7SwwBE37t J7alZ7dG3ehujpkqW0oTODI3//tMhinRfCdUuUYNcTsaHzgLmUE6KDNWm3ZJGinrgA70 Y+p4PINSziIfZw3BOZXq/2yRu4vpBidPfnjJkyMlK5iFiaE13U8iXB3RkzC/f7j0gHnb 50AXQZjWr+pyB7bRdqzvGvGpaf1jBT2A/XNeo+NjvZEFWFs4BrjKY1qaAoAy/dx6Vipu 3Edw== X-Gm-Message-State: APjAAAWP8ITCMU1tMa1nGLtSHGdc3aJfyNIU/7KCMAFpI0aaX9/h7RT3 0gLAwcqxXdUm8ZhYlVEoUCM= X-Google-Smtp-Source: APXvYqzOQ+Lu5lRGswb5Z2P63WBfRUX8mHoz+s2loSkaKvwV6H4Mbw7THqFtMSlONX7MfN0SJPM6cg== X-Received: by 2002:a17:902:3183:: with SMTP id x3mr42274620plb.170.1554878240246; Tue, 09 Apr 2019 23:37:20 -0700 (PDT) Received: from Asurada (c-98-248-47-108.hsd1.ca.comcast.net. [98.248.47.108]) by smtp.gmail.com with ESMTPSA id 143sm69811465pge.50.2019.04.09.23.37.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2019 23:37:20 -0700 (PDT) Date: Tue, 9 Apr 2019 23:37:14 -0700 From: Nicolin Chen To: Daniel Baluta Subject: Re: [alsa-devel] [PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute Message-ID: <20190410063714.GA4156@Asurada> References: <1554809242-27475-1-git-send-email-viorel.suman@nxp.com> <1554809242-27475-2-git-send-email-viorel.suman@nxp.com> <20190410042906.GC3032@Asurada> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_233720_994338_083A6CB3 X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Fabio Estevam , Pengutronix Kernel Team , Timur Tabi , Xiubo Li , "linux-arm-kernel@lists.infradead.org" , Shawn Guo , Sascha Hauer , Takashi Iwai , Liam Girdwood , Viorel Suman , Julia Lawall , Rob Herring , Mark Brown , Viorel Suman , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 10, 2019 at 09:20:29AM +0300, Daniel Baluta wrote: > Hi Nicolin, > > On Wed, Apr 10, 2019 at 7:30 AM Nicolin Chen wrote: > > > > On Tue, Apr 09, 2019 at 11:27:39AM +0000, Viorel Suman wrote: > > > Use "of_device_id.data" to specify the machine driver > > > instead of "model" DTS attribute. > > > > > > Signed-off-by: Viorel Suman > > > > Acked-by: Nicolin Chen > > > > > --- > > > sound/soc/fsl/fsl_audmix.c | 43 +++++++++++++++++++++++-------------------- > > > 1 file changed, 23 insertions(+), 20 deletions(-) > > > > > + priv->pdev = platform_device_register_data(&pdev->dev, mdrv, 0, NULL, > > > + 0); > > > > Would you please send a separate patch to replace "pdev->dev"? > > I am not sure exactly how to explain this change in the commit message. It does > make code easier to read and avoids dereferencing pdev pointer each time. > > Is it enough for commit description? You mean this? https://lore.kernel.org/patchwork/patch/862610/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel