From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A6AC10F11 for ; Wed, 10 Apr 2019 08:57:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77B47206B6 for ; Wed, 10 Apr 2019 08:57:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a+K2UsSm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77B47206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SxYElnsIhhz0CzX9BfnJ5VnYuK/CZk9OVaF3W06UjHE=; b=a+K2UsSmOTfKmG dM31q2DxGMnWnU75UAOjy7fGzdXE+KzrTgF27Ucfz+aeSVx2pX9aaf7aPQGns4BseJ9QnI0b2QtFb A3u2AG7nXViGaRtYS0BYfti3F238z9wmT6g1i6ek2lKL6WfQ8MK69WES31ujIvlZy/y559Wh5Z8rJ 3zkeUnDuytHP8gk73LL4zHIrajrrnNa4h9ipQo+RFlAWkdSx94RnO0bXZ9HIBBcDtgy0ZgwOzUYnw lY0u7QXvKbDiMoujD+rGalV2zuKXeuavt+jYY/5K7cuGGMZD0qDT0yo9jkiguOVVT1Q9pmbOizu0c z5SGqeGGkJ1fyPM0PX6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hE92g-0006N7-6r; Wed, 10 Apr 2019 08:57:14 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hE92d-0006Lr-90 for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2019 08:57:12 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 55BC5374; Wed, 10 Apr 2019 01:57:08 -0700 (PDT) Received: from queper01-lin (queper01-lin.cambridge.arm.com [10.1.195.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ED1D73F59C; Wed, 10 Apr 2019 01:57:05 -0700 (PDT) Date: Wed, 10 Apr 2019 09:57:04 +0100 From: Quentin Perret To: Viresh Kumar Subject: Re: [PATCH 3/3] thermal: cpu_cooling: Migrate to using the EM framework Message-ID: <20190410085702.nll6spd565oio3ds@queper01-lin> References: <20190328101352.25657-1-quentin.perret@arm.com> <20190328101352.25657-4-quentin.perret@arm.com> <20190410054449.zwmemg7vza557gue@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190410054449.zwmemg7vza557gue@vireshk-i7> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_015711_318240_8820C1E1 X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, rjw@rjwysocki.net, amit.kachhap@gmail.com, daniel.lezcano@linaro.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, edubezval@gmail.com, catalin.marinas@arm.com, rui.zhang@intel.com, javi.merino@kernel.org, ionela.voinescu@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 10 Apr 2019 at 11:14:49 (+0530), Viresh Kumar wrote: > On 28-03-19, 10:13, Quentin Perret wrote: > > +static unsigned int get_state_freq(struct cpufreq_cooling_device *cpufreq_cdev, > > + unsigned long state) > > +{ > > + struct cpufreq_policy *policy; > > + unsigned long idx; > > + > > + /* Use the Energy Model table if available */ > > + if (cpufreq_cdev->em) { > > + idx = cpufreq_cdev->max_level - state; > > + return cpufreq_cdev->em->table[idx].frequency; > > + } > > + > > + /* Otherwise, fallback on the CPUFreq table */ > > + policy = cpufreq_cdev->policy; > > + if (policy->freq_table_sorted == CPUFREQ_TABLE_SORTED_ASCENDING) > > It is not guaranteed that the frequency table is sorted in any order, isn't it ? Hmm, indeed... I thought cpufreq_table_validate_and_sort() was actively sorting the table but it seems I was wrong. But I _think_ in practice the freq table actually happens to be sorted for the upstream cpufreq drivers with the CPUFREQ_IS_COOLING_DEV flag set. Most of them use dev_pm_opp_init_cpufreq_table() which guarantees the table is sorted and qoriq-cpufreq explicitly sorts the table. But I'm not sure about qcom-cpufreq-hw ... So, if the above is true, perhaps I could simply add a check to mandate that policy->freq_table_sorted != CPUFREQ_TABLE_SORTED_UNSORTED for cpu_cooling ? That shouldn't harm the existing users. Do you happen to know a board where the table is unsorted ? Is it a common use-case ? If yes, then I'll probably need to drop the dependency on cpufreq's freq_table and use something else to convert indexes into frequencies (PM_OPP ?). Unless we can force-sort the table in the cpufreq core, but that might require lots of changes to lots of drivers too. > > > + idx = cpufreq_cdev->max_level - state; > > + else > > + idx = state; > > -- > viresh Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel