From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3B93C10F11 for ; Wed, 10 Apr 2019 10:24:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 829FA2075B for ; Wed, 10 Apr 2019 10:24:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S5TkRtRH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 829FA2075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MKjOmYERnJB5poDTtliX2+swt5e+pyu6y/b+cXSskEw=; b=S5TkRtRHgu0bgs 5poYf8bXENvmg6LDGPMQAVo6H9n2RxfRrlKZLqxnNed7quaDvOAZPZVv+XZgNU3zsqEnLUs/IHHi6 2zAq1dwXCiUcfVdjG5JUeaxzNe9VBAnTjqhzkrXTs29MaFJwBYJjTPFv3ccEU+ufR9Nh/BieonKja lqatZJsy0vhG5FqexYnxDoCJ8QQadShJeLt/1cXAFMKffO1aQWJzOcoipKHMTFER29Zo2lyIFAFla hi5eUHCaY04hJqS5VEgyXtRbt+PVhGPjqVnEhq9NlO2ZwxeFql1LgO0Mo2VDZhI6z6KCvrZUGyLZV TSUaHeK06O+29AtWPg1A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEAP4-0005Bi-Nm; Wed, 10 Apr 2019 10:24:26 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEAP2-0005An-5I; Wed, 10 Apr 2019 10:24:25 +0000 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 03:24:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="163012781" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 10 Apr 2019 03:24:16 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Wed, 10 Apr 2019 13:24:15 +0300 Date: Wed, 10 Apr 2019 13:24:15 +0300 From: Heikki Krogerus To: Chunfeng Yun Subject: Re: [v3 PATCH 6/6] usb: mtu3: register a USB Role Switch for dual role mode Message-ID: <20190410102415.GH20058@kuha.fi.intel.com> References: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> <1554257354-7440-7-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1554257354-7440-7-git-send-email-chunfeng.yun@mediatek.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_032424_253711_6E3E9F63 X-CRM114-Status: GOOD ( 11.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Hans de Goede , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , Alan Stern , Min Guo , Matthias Brugger , linux-mediatek@lists.infradead.org, Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 03, 2019 at 10:09:14AM +0800, Chunfeng Yun wrote: > +static int ssusb_role_sw_register(struct otg_switch_mtk *otg_sx) > +{ > + struct usb_role_switch_desc role_sx_desc = { 0 }; > + struct ssusb_mtk *ssusb = > + container_of(otg_sx, struct ssusb_mtk, otg_switch); > + > + if (!otg_sx->role_sw_used) > + return 0; > + > + role_sx_desc.set = ssusb_role_sw_set; > + role_sx_desc.get = ssusb_role_sw_get; role_sw_desc.fwnode = dev_fwnode(ssusb->dev); > + otg_sx->role_sw = usb_role_switch_register(ssusb->dev, &role_sx_desc); > + > + return PTR_ERR_OR_ZERO(otg_sx->role_sw); > +} thanks, -- heikki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel