From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA74EC10F11 for ; Wed, 10 Apr 2019 10:36:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A884C20830 for ; Wed, 10 Apr 2019 10:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hP6U2uOq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A884C20830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wg2wQeYC597BGZK8UtFX4HUU+QTEid0RkO0TqcBpz8w=; b=hP6U2uOqsL+m7e LYlm1v82iDL7fsuvpUAO0eBXl1VaqwbqcQYwQKAQ8ReoKjp0eZ7jRy9hk5SHOTFRvo2qD6p8MGA5B jTWeaa2+6NDO2Kl7eWlec3eHt0knMcixVi2nNS0W2/pUgJxhdBSn/J53wjc6wvLPB2m9cWlVU1Chu GZJMXUMTPvgktBt3ogutvLfO4xGQOTmAMMyMJnyR3i+cvjbG8+K59J3hs4p+mMls+ZxJZLNR8SP6j BvmBCrPMY2VM1FMzBLMUehCQLD2wShyvl7h6NG3PhGeql6h8y/+u6IIklgIO3S3P2htj/5ji7pv8V BjWNIRfIyNF7xCRglvAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEAbC-00034X-4E; Wed, 10 Apr 2019 10:36:58 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEAb7-00031p-Ng for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2019 10:36:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E26A15AB; Wed, 10 Apr 2019 03:36:53 -0700 (PDT) Received: from queper01-lin (queper01-lin.cambridge.arm.com [10.1.195.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D73893F59C; Wed, 10 Apr 2019 03:36:50 -0700 (PDT) Date: Wed, 10 Apr 2019 11:36:45 +0100 From: Quentin Perret To: Viresh Kumar Subject: Re: [PATCH 3/3] thermal: cpu_cooling: Migrate to using the EM framework Message-ID: <20190410103642.gopsoixrpc4nfuxz@queper01-lin> References: <20190328101352.25657-1-quentin.perret@arm.com> <20190328101352.25657-4-quentin.perret@arm.com> <20190410054449.zwmemg7vza557gue@vireshk-i7> <20190410085702.nll6spd565oio3ds@queper01-lin> <20190410101423.3pl6yfhv2wnxuwgw@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190410101423.3pl6yfhv2wnxuwgw@vireshk-i7> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_033653_843256_0A25F2B6 X-CRM114-Status: GOOD ( 15.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, rjw@rjwysocki.net, amit.kachhap@gmail.com, daniel.lezcano@linaro.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, edubezval@gmail.com, catalin.marinas@arm.com, rui.zhang@intel.com, javi.merino@kernel.org, ionela.voinescu@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 10 Apr 2019 at 15:44:23 (+0530), Viresh Kumar wrote: > On 10-04-19, 09:57, Quentin Perret wrote: > > Hmm, indeed... I thought cpufreq_table_validate_and_sort() was actively > > sorting the table but it seems I was wrong. > > > > But I _think_ in practice the freq table actually happens to be sorted > > for the upstream cpufreq drivers with the CPUFREQ_IS_COOLING_DEV flag > > set. Most of them use dev_pm_opp_init_cpufreq_table() which guarantees > > the table is sorted and qoriq-cpufreq explicitly sorts the table. But > > I'm not sure about qcom-cpufreq-hw ... > > > > So, if the above is true, perhaps I could simply add a check to mandate > > that policy->freq_table_sorted != CPUFREQ_TABLE_SORTED_UNSORTED for > > cpu_cooling ? That shouldn't harm the existing users. > > Right, I think most of the platforms will have it sorted anyway right now, but > you never know if one or two of them don't. Maybe just add the above conditional > and put out an error or WARN or something, so people know that something broke. Right, WARN + bail out should do it. I'll do the change in v2. Thanks ! Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel