From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD6D3C10F11 for ; Wed, 10 Apr 2019 15:50:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A95220830 for ; Wed, 10 Apr 2019 15:50:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XPfowRLr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A95220830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=joZHSD3ACeba1MJTqVBoS5jrzbYZ5LpJub7hbu58k+w=; b=XPfowRLr7+i9Is Q7GS0N/E3fYI2G5OdHZMXDV1oSwQHsUpLH51EL1yZnCbOe9pWJwpNN1qAV5uZ/wkQMp9D+VNlwObM zWiXKuf54N3EOxLDCIAp805Qjo+r73SZod6zz+SNx5gySpk/iaLH4Kpf1mwKtSp+kUQC4I3vEXrL1 pXxLhsZWluSXy4Gi6Rv8r0ReS4/Bbmtv+9dJyoTeqVWUIvKXH0j6S7+1Buycz/ZOO+NznjQhHcW3P 7NdghpiNDWRmn+1B7Uk/SRW1LIRFi8Wb2kzvLTbdZDr6U9+bcXol7fpEmWHAXZZ311UtEY7KqwICy jVOctpVVuLfT10KIJ2tA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEFUF-0006De-MA; Wed, 10 Apr 2019 15:50:07 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEFUC-0005lv-UA for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2019 15:50:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 03759374; Wed, 10 Apr 2019 08:50:04 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 166D33F59C; Wed, 10 Apr 2019 08:50:02 -0700 (PDT) Date: Wed, 10 Apr 2019 16:50:00 +0100 From: Sudeep Holla To: Steven Price Subject: Re: [PATCH] firmware: arm_scmi: Fix leak in scmi_mailbox_check Message-ID: <20190410155000.GD3952@e107155-lin> References: <20190325173722.49414-1-steven.price@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190325173722.49414-1-steven.price@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_085004_984011_33D87233 X-CRM114-Status: UNSURE ( 9.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 25, 2019 at 05:37:22PM +0000, Steven Price wrote: > of_parse_phandle_with_args() requires the caller to call of_node_put() on > the returned args->np pointer. Otherwise the reference count will remain > incremented. > Good find and thanks for the fix. > However, in this case, since we don't actually use the returned pointer, > we can simply pass in NULL. > > Fixes: aa4f886f3893f ("firmware: arm_scmi: add basic driver infrastructure for SCMI") > Signed-off-by: Steven Price Applied. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel