From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7242CC10F11 for ; Wed, 10 Apr 2019 16:10:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41CFF206B6 for ; Wed, 10 Apr 2019 16:10:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TEul66zb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41CFF206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m37nTaFXT9Wu2tXqdlldqJjX3iUyaEY0Bg2qEjiJzwk=; b=TEul66zbsjVJje OHKnw9WBqBx63sjZxDawyerPVFe4n99DQNzQBWNeaU+Q1UcTdmHyiV0nGeKOQqIanhnUrdyr/MfB4 Y5vWzXOjkBIWNLvnAqJJLAvTnamOvicWIx7irpDNPPIBKJkUH75fq16gRl5zwFdqo3JvoelWPChJ7 8QI+SvBbn2Znkj8bfDKWUqwihtCKiuryIc1NGHw28qIkrBRookG27lMb2Bv4h+0RfpAES1vKYcD7I 9BC8QnqR32zzKYtWe0HSdLyhbpGmWOV4kstpNlndSm0arWNpVTQJ+pnRI9leDmd6kfJPgjLd4RO4i CHE0+VdxXuAXu1Ve4Iig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEFnm-0006yr-C0; Wed, 10 Apr 2019 16:10:18 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEFnk-0006yR-00 for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2019 16:10:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 10F76374; Wed, 10 Apr 2019 09:10:15 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 01E093F59C; Wed, 10 Apr 2019 09:10:13 -0700 (PDT) Date: Wed, 10 Apr 2019 17:10:11 +0100 From: Sudeep Holla To: Aditya Pakki Subject: Re: [PATCH v2] firmware: arm_scmi: Fix to replace of_match_device Message-ID: <20190410161011.GE3952@e107155-lin> References: <20190322215503.13434-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190322215503.13434-1-pakki001@umn.edu> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_091016_044435_E88EB203 X-CRM114-Status: GOOD ( 18.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kjlu@umn.edu, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 22, 2019 at 04:55:03PM -0500, Aditya Pakki wrote: > of_match_device can return NULL if no matching device is found. > This patch replaces the function with of_device_get_match_data. > and returns -EINVAL in such a scenario. > > Signed-off-by: Aditya Pakki > > --- > v1: Replace of_match_device with of_device_get_match_data > --- > drivers/firmware/arm_scmi/driver.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 8f952f2f1a29..a44852a1d5bc 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -798,7 +798,9 @@ static int scmi_probe(struct platform_device *pdev) > return -EINVAL; > } > > - desc = of_match_device(scmi_of_match, dev)->data; probe won't be called be there's no match. And we mandate data in the driver, so this should never happen. > + desc = of_device_get_match_data(dev); Having said that, I am happy to use the above function. > + if (!desc) > + return -EINVAL; > NULL check seems totally unnecessary, but it's in probe so I am fine. Applied with updates to subject and commit message. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel