From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C927AC10F11 for ; Thu, 11 Apr 2019 01:49:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95CAD20850 for ; Thu, 11 Apr 2019 01:49:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dqlNnxv4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0+u0T2Tk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95CAD20850 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eE0ba+jLUIARMUFWjvfdkdcAUnKCfXfgoITKAAWxjdA=; b=dqlNnxv4/VPApi +u5yvtnnTLPaHQ+Iojz8yrIz4bgNWUOpxWQyX/MKVNjpn5y1epA6kyHTX11HvZNhMZWwMufK+iOJU 49U4JCrzuavpuQ2eHf7Am5c5hZtYfQMlCHLs2tWrLp1HA8fw3Thzv/13dLKUzEIFfGS5DxL/3Zptz UwqyyuAaD1QJDmPOAaahGt6Yc6zSlLZvxVk3v3o9S7pPeyduovgyIukLmq4BKxKe+1pP8QzNJPE9H mz1aWA6Hc57m/r5flJIguWsXEDMSqDj5epkpNog3cttPH1LIUCleK9tRyVH8syHGH6mp3gLsUk2vP nGxEBXzpHjUEVH2yFiYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEOqE-000194-IL; Thu, 11 Apr 2019 01:49:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEOqA-00018j-Gy for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 01:49:24 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D95020850; Thu, 11 Apr 2019 01:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554947362; bh=4TZuZH6H4RysAjo+nmyy0kG0fcoLjP/vxfzWmuBezGc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0+u0T2TkvCqr3wIJekKU7kXOZkQGIdBIc3MCkjenVD5eBdEfVL9PT09+ATCYHnr9B V4bCKuURhGPmRskYhdON0XTWnGF0czeCGMBzKw2bfbD1EaMTKmvgyqV46HEPF7lVvt J3kjMg3EF5QT3C7crt82x/wbTUdCsreMJDCsFW+s= Date: Thu, 11 Apr 2019 09:49:10 +0800 From: Shawn Guo To: Marek Vasut Subject: Re: [PATCH V4 3/3] ARM: dts: imx53: Add Menlosystems M53 board Message-ID: <20190411014908.GG26817@dragon> References: <20190321025655.15031-1-marex@denx.de> <20190321025655.15031-3-marex@denx.de> <20190326084229.GI12513@dragon> <7df4b7cf-7206-e7dd-11ba-2e899a33b861@denx.de> <20190329024757.GN12513@dragon> <0613e943-bd8c-e119-76a9-1a818986a8e5@denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0613e943-bd8c-e119-76a9-1a818986a8e5@denx.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_184922_603170_675F264A X-CRM114-Status: GOOD ( 21.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 09, 2019 at 02:49:58PM +0200, Marek Vasut wrote: > On 3/29/19 3:47 AM, Shawn Guo wrote: > > On Tue, Mar 26, 2019 at 05:44:41PM +0100, Marek Vasut wrote: > >> On 3/26/19 9:42 AM, Shawn Guo wrote: > >>> On Thu, Mar 21, 2019 at 03:56:55AM +0100, Marek Vasut wrote: > >>>> Add device tree for the Menlosystems board based on i.MX53 M53 SoM. > >>>> > >>>> Signed-off-by: Marek Vasut > >>>> Cc: Shawn Guo > >>>> Cc: Fabio Estevam > >>>> Cc: NXP Linux Team > >>>> To: linux-arm-kernel@lists.infradead.org > >>>> --- > >>>> V2: - Rebase on latest next/master > >>>> V3: - Add vendor specific compatible for the platform > >>>> - Rename ledgrp and touchscreen nodes to follow DT spec > >>>> - Update pinmux (LVDS has no pin config, so use default settings) > >>>> V4: - Add fsl.yaml entry > >>>> - Pull regulator out of simple bus > >>>> - Rename touchscreen@ node > >>>> - Add reg entry to lvds-channel@0 > >>>> - Fix touchscreen interrupt polarity > >>>> --- > >>>> .../devicetree/bindings/arm/fsl.yaml | 1 + > >>> > >>> We need to make the bindings a separate patch and be ACK-ed by DT folks. > >> > >> Sure. > >> > >>>> arch/arm/boot/dts/Makefile | 1 + > >>>> arch/arm/boot/dts/imx53-m53menlo.dts | 310 ++++++++++++++++++ > >>>> 3 files changed, 312 insertions(+) > >>>> create mode 100644 arch/arm/boot/dts/imx53-m53menlo.dts > >>>> > >> > >> [...] > >> > >>>> + pinctrl_lvds0: lvds0grp { > >>>> + fsl,pins = < > >>>> + MX53_PAD_LVDS0_CLK_P__LDB_LVDS0_CLK 0x80000000 > >>>> + MX53_PAD_LVDS0_TX0_P__LDB_LVDS0_TX0 0x80000000 > >>>> + MX53_PAD_LVDS0_TX1_P__LDB_LVDS0_TX1 0x80000000 > >>>> + MX53_PAD_LVDS0_TX2_P__LDB_LVDS0_TX2 0x80000000 > >>>> + MX53_PAD_LVDS0_TX3_P__LDB_LVDS0_TX3 0x80000000 > >>> > >>> Please have proper pad configurations rather than relying on the > >>> settings out of reset or set up by bootloader. > >> > >> Do you have an example LVDS configuration for the MX53 ? I didn't find > >> one, all the other boards just leave the LVDS line configuration in > >> default settings. > > > > Sorry, I do not. If your bootloader doesn't touch the settings, you may > > just need to code the reset values from reference manual here? > > The reference manual only indicates there's a MUX_MODE bit for those > signals, there are no other configuration values. So I presume this is > actually correct ? Configuring the pads with unknown values is not a correct thing to me. Again, we are trying to get away from using 0x80000000, so please do not introduce more. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel