From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BF78C10F11 for ; Thu, 11 Apr 2019 02:30:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BF80217D4 for ; Thu, 11 Apr 2019 02:30:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MTcAXrQX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="XzI9MzJd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BF80217D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hAgEKdklB6LvUN+uutMmsxZIc7C8rMhAvNP4d/rty3M=; b=MTcAXrQX70FK0d YICkGVg1pS5X1+kcXloojCq317Rr4S6kMw682qB3znvLVbQIKtgJ+XMQ3U0Ar14xabIdAM5ZNx2U5 zvkHcgxd3YCYjneCM3TxLRPNFnpPtfhfAGXPhd0lMiX39YHDmhAlcCCALk6HXfIL92hePC8dPs8Us sEnzlTRFhkpXmxouSW45aXeCRPVJCPbkZqEBb69evgGZEa9t4oakJ1HQbRK2aQ+XmvgdML3d99eBO ymeimhhXW4vdVnvGhBHfJJ4yFbtuVTR0ry3E0NXr0TMWRAz9kb4WnxJk5Jn2cA6dY1Bmg7YqLsqvD hHsamfi6MxFkf3GzhJxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEPTu-0006GQ-4N; Thu, 11 Apr 2019 02:30:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEPTq-0006DE-B4 for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 02:30:24 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2C12217D4; Thu, 11 Apr 2019 02:30:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554949821; bh=K1dDvojhPy/Vthioed5xtthZuN9kDbzoLUWlKZY0Pto=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XzI9MzJd7WcqpyBOKeyD2BECO+I+hvmFPwwPQQLBjKYXJbgsQzEYtzYdY7y6hG5Ok 0k0tX7D/ltNeZWvkgvWAOWijWhCECWRLuoPb0B7L14Yc4DPOoBSioONuVr0dNFej9H QO2yraCIHydz8I5f+Wr7EbYlND0Nh0rNbGy4L/6Q= Date: Thu, 11 Apr 2019 10:30:09 +0800 From: Shawn Guo To: Andrey Smirnov Subject: Re: [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA Message-ID: <20190411023008.GK26817@dragon> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_193022_447515_8279575C X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 28, 2019 at 11:49:16PM -0700, Andrey Smirnov wrote: > Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" > clock to determine if it needs to configure the IP block as operating > at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both > clocks as IMX6QDL_CLK_SDMA results in driver incorrectly thinking that > ratio is 1:1 which results in broken SDMA funtionality(this at least > breaks RAVE SP serdev driver on RDU2). Fix the code to specify > IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect > clock ratio. > > Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Since we have a fix in the dma driver, I dropped the Fixes tag here. Applied all, thanks. Shawn > Signed-off-by: Andrey Smirnov > Reviewed-by: Lucas Stach > Cc: Angus Ainslie (Purism) > Cc: Chris Healy > Cc: Lucas Stach > Cc: Fabio Estevam > Cc: Shawn Guo > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/boot/dts/imx6qdl.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index 9f9aa6e7ed0e..354feba077b2 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -949,7 +949,7 @@ > compatible = "fsl,imx6q-sdma", "fsl,imx35-sdma"; > reg = <0x020ec000 0x4000>; > interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clks IMX6QDL_CLK_SDMA>, > + clocks = <&clks IMX6QDL_CLK_IPG>, > <&clks IMX6QDL_CLK_SDMA>; > clock-names = "ipg", "ahb"; > #dma-cells = <3>; > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel