From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 639ABC10F11 for ; Thu, 11 Apr 2019 02:58:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A0AA217F4 for ; Thu, 11 Apr 2019 02:58:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qx4SZdr+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="m+FpkN89" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A0AA217F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nhdcfMSkwR8qQiAOOyK5s8tRRzQZIA7esvWvnA9072s=; b=qx4SZdr+tQFmZ4 DF/AmVc8Ul9O7U//ofvhGIhMzNHcef5OVstIJalVX0c6IUgVhL0z6j7+woN7lo+euqq+5baTnXPCv swyVHzo5GXTN+Qzrxz6iYaa8almkEaaTiuKyluV0CslaEEdkGlgp6m0pigUk/gzAH6QgHLa5yeET1 Pn3yIqF68EehZ8uVNDHR0+Z4RPc+QbtgNAmp80NMJUPfsdKDA8hvSbqL3zPVdWI2pqZ8ySHFyLMK0 hc6Es93XvKJGTJB65u2mgSszVTK9jnblvM3faVS6mFeG64qQg6zVjnneFEWMOiyHvKlMoDKqGlzns L0Eim+I0PPMBTjPbok+Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEPvC-0005l7-Mu; Thu, 11 Apr 2019 02:58:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEPvA-0005kl-Ho for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 02:58:37 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9759D20818; Thu, 11 Apr 2019 02:58:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554951516; bh=6Xz0Wlr69Yydid3ATJXt9AbloYkoghMh/ETFXw/qBl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m+FpkN89SN0Znay5Dxl1Mpz4XKg+Sh/C8ATHyssxFU653fl3RbJ+k8NF2jCupMY76 4WOng5WvOp08EM2PmCTjIGKE2LBhK0cQ5R/vxuT3o1ewPGoOZq+2n+R8Azb12KLWzY Hez6Q0D2kuJ8psEbxluyylregKAZZkFjJ0zX5TeY= Date: Thu, 11 Apr 2019 10:58:20 +0800 From: Shawn Guo To: Fabio Estevam Subject: Re: [PATCH v3] ARM: dts: imx: Fix the AR803X phy-mode Message-ID: <20190411025818.GM26817@dragon> References: <20190403221241.4753-1-festevam@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190403221241.4753-1-festevam@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_195836_605818_A2B9579C X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, baruch@tkos.co.il, ken.lin@advantech.com, smoch@web.de, stwiss.opensource@diasemi.com, linux-imx@nxp.com, kernel@pengutronix.de, Marc Kleine-Budde , aford173@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 03, 2019 at 07:12:41PM -0300, Fabio Estevam wrote: > Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") > exposed an issue on imx DTS files using AR8031/AR8035 PHYs. > > The end result is that the boards can no longer obtain an IP address > via UDHCP, for example. > > Quoting Andrew Lunn: > > "The problem here is, all the DTs were broken since day 0. However, > because the PHY driver was also broken, nobody noticed and it > worked. Now that the PHY driver has been fixed, all the bugs in the > DTs now become an issue" > > To fix this problem, the phy-mode property needs to be "rgmii-id", which > has the following meaning as per > Documentation/devicetree/bindings/net/ethernet.txt: > > "RGMII with internal RX and TX delays provided by the PHY, the MAC should > not add the RX or TX delays in this case)" > > Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with > successfully restored networking. > > Based on the initial submission from Steve Twiss for the > imx6qdl-sabresd. > > Signed-off-by: Fabio Estevam > Tested-by: Baruch Siach > Tested-by: Soeren Moch > Tested-by: Steve Twiss > Tested-by: Adam Thomson > Signed-off-by: Steve Twiss > Tested-by: Marc Kleine-Budde > Signed-off-by: Marc Kleine-Budde Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel