From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Marek Vasut <marex@denx.de>, NXP Linux Team <linux-imx@nxp.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V4 3/3] ARM: dts: imx53: Add Menlosystems M53 board
Date: Thu, 11 Apr 2019 11:15:37 +0800 [thread overview]
Message-ID: <20190411031534.GP26817@dragon> (raw)
In-Reply-To: <CAOMZO5B=aX0Lo+MVLqgO254iv5LBkM2KH1w1c6wf7U8bRgvhpg@mail.gmail.com>
On Wed, Apr 10, 2019 at 11:30:01PM -0300, Fabio Estevam wrote:
> Hi Shawn,
>
> On Wed, Apr 10, 2019 at 10:49 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> > > The reference manual only indicates there's a MUX_MODE bit for those
> > > signals, there are no other configuration values. So I presume this is
> > > actually correct ?
> >
> > Configuring the pads with unknown values is not a correct thing to me.
> > Again, we are trying to get away from using 0x80000000, so please do not
> > introduce more.
>
> Looking at the i.MX53 Reference these LVDS pins look different from
> the others because they do not have the associated IOMUXC_SW_PAD_CTL
> register, only the IOMUXC_SW_MUX_CTL_PAD_LVDS0_CLK_P is present. This
> means that we don't have a real value to put in the devicetree, so
> 0x80000000 makes sense in this case.
Okay. @Marek, please add the comment into the code.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-04-11 3:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 2:56 [PATCH V4 1/3] of: Add vendor prefix for Menlo Systems GmbH Marek Vasut
2019-03-21 2:56 ` [PATCH V4 2/3] ARM: dts: imx53: Rename M53 SoM touchscreen node Marek Vasut
2019-03-21 2:56 ` [PATCH V4 3/3] ARM: dts: imx53: Add Menlosystems M53 board Marek Vasut
2019-03-26 8:42 ` Shawn Guo
2019-03-26 16:44 ` Marek Vasut
2019-03-29 2:47 ` Shawn Guo
2019-04-09 12:49 ` Marek Vasut
2019-04-11 1:49 ` Shawn Guo
2019-04-11 2:30 ` Fabio Estevam
2019-04-11 3:15 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411031534.GP26817@dragon \
--to=shawnguo@kernel.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).