* [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource() to simplify code
@ 2019-04-01 6:07 Anson Huang
2019-04-01 6:07 ` [PATCH 2/2] soc: imx: gpcv2: " Anson Huang
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Anson Huang @ 2019-04-01 6:07 UTC (permalink / raw)
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, Leonard Crestez,
ulf.hansson@linaro.org, Sven.Schmitt@mixed-mode.de,
vivek.gautam@codeaurora.org, andrew.smirnov@gmail.com,
l.stach@pengutronix.de, robh@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: dl-linux-imx
Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/soc/imx/gpc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
index 7d14a4b..a8f1e47 100644
--- a/drivers/soc/imx/gpc.c
+++ b/drivers/soc/imx/gpc.c
@@ -406,7 +406,6 @@ static int imx_gpc_probe(struct platform_device *pdev)
const struct imx_gpc_dt_data *of_id_data = of_id->data;
struct device_node *pgc_node;
struct regmap *regmap;
- struct resource *res;
void __iomem *base;
int ret;
@@ -417,8 +416,7 @@ static int imx_gpc_probe(struct platform_device *pdev)
!pgc_node)
return 0;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(&pdev->dev, res);
+ base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(base))
return PTR_ERR(base);
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] soc: imx: gpcv2: use devm_platform_ioremap_resource() to simplify code
2019-04-01 6:07 [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource() to simplify code Anson Huang
@ 2019-04-01 6:07 ` Anson Huang
2019-04-01 7:49 ` Mukesh Ojha
2019-04-01 7:48 ` [PATCH 1/2] soc: imx: gpc: " Mukesh Ojha
2019-04-11 5:28 ` Shawn Guo
2 siblings, 1 reply; 5+ messages in thread
From: Anson Huang @ 2019-04-01 6:07 UTC (permalink / raw)
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, Leonard Crestez,
ulf.hansson@linaro.org, Sven.Schmitt@mixed-mode.de,
vivek.gautam@codeaurora.org, andrew.smirnov@gmail.com,
l.stach@pengutronix.de, robh@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: dl-linux-imx
Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/soc/imx/gpcv2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
index e06bf12..31b8d00 100644
--- a/drivers/soc/imx/gpcv2.c
+++ b/drivers/soc/imx/gpcv2.c
@@ -563,7 +563,6 @@ static int imx_gpcv2_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct device_node *pgc_np, *np;
struct regmap *regmap;
- struct resource *res;
void __iomem *base;
int ret;
@@ -573,8 +572,7 @@ static int imx_gpcv2_probe(struct platform_device *pdev)
return -EINVAL;
}
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(dev, res);
+ base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(base))
return PTR_ERR(base);
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] soc: imx: gpcv2: use devm_platform_ioremap_resource() to simplify code
2019-04-01 6:07 ` [PATCH 2/2] soc: imx: gpcv2: " Anson Huang
@ 2019-04-01 7:49 ` Mukesh Ojha
0 siblings, 0 replies; 5+ messages in thread
From: Mukesh Ojha @ 2019-04-01 7:49 UTC (permalink / raw)
To: Anson Huang, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, Leonard Crestez,
ulf.hansson@linaro.org, Sven.Schmitt@mixed-mode.de,
vivek.gautam@codeaurora.org, andrew.smirnov@gmail.com,
l.stach@pengutronix.de, robh@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: dl-linux-imx
On 4/1/2019 11:37 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/soc/imx/gpcv2.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index e06bf12..31b8d00 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -563,7 +563,6 @@ static int imx_gpcv2_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct device_node *pgc_np, *np;
> struct regmap *regmap;
> - struct resource *res;
> void __iomem *base;
> int ret;
>
> @@ -573,8 +572,7 @@ static int imx_gpcv2_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource() to simplify code
2019-04-01 6:07 [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource() to simplify code Anson Huang
2019-04-01 6:07 ` [PATCH 2/2] soc: imx: gpcv2: " Anson Huang
@ 2019-04-01 7:48 ` Mukesh Ojha
2019-04-11 5:28 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Mukesh Ojha @ 2019-04-01 7:48 UTC (permalink / raw)
To: Anson Huang, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, Leonard Crestez,
ulf.hansson@linaro.org, Sven.Schmitt@mixed-mode.de,
vivek.gautam@codeaurora.org, andrew.smirnov@gmail.com,
l.stach@pengutronix.de, robh@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: dl-linux-imx
On 4/1/2019 11:37 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/soc/imx/gpc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index 7d14a4b..a8f1e47 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -406,7 +406,6 @@ static int imx_gpc_probe(struct platform_device *pdev)
> const struct imx_gpc_dt_data *of_id_data = of_id->data;
> struct device_node *pgc_node;
> struct regmap *regmap;
> - struct resource *res;
> void __iomem *base;
> int ret;
>
> @@ -417,8 +416,7 @@ static int imx_gpc_probe(struct platform_device *pdev)
> !pgc_node)
> return 0;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource() to simplify code
2019-04-01 6:07 [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource() to simplify code Anson Huang
2019-04-01 6:07 ` [PATCH 2/2] soc: imx: gpcv2: " Anson Huang
2019-04-01 7:48 ` [PATCH 1/2] soc: imx: gpc: " Mukesh Ojha
@ 2019-04-11 5:28 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2019-04-11 5:28 UTC (permalink / raw)
To: Anson Huang
Cc: robh@kernel.org, ulf.hansson@linaro.org,
vivek.gautam@codeaurora.org, Sven.Schmitt@mixed-mode.de,
s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
andrew.smirnov@gmail.com, dl-linux-imx, kernel@pengutronix.de,
Leonard Crestez, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de
On Mon, Apr 01, 2019 at 06:07:08AM +0000, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Applied both, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-11 5:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-01 6:07 [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource() to simplify code Anson Huang
2019-04-01 6:07 ` [PATCH 2/2] soc: imx: gpcv2: " Anson Huang
2019-04-01 7:49 ` Mukesh Ojha
2019-04-01 7:48 ` [PATCH 1/2] soc: imx: gpc: " Mukesh Ojha
2019-04-11 5:28 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).